Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my project code to 'homeworks' - HTML-CSS-Popup #26

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Added my project code to 'homeworks' - HTML-CSS-Popup #26

merged 3 commits into from
Jul 29, 2022

Conversation

Acerpo
Copy link
Contributor

@Acerpo Acerpo commented Jul 28, 2022

HTML-CSS-Popup

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
See my comments below, also, if you want check how looks/works your popup in firefox)

submissions/acerpo/index.html Outdated Show resolved Hide resolved
submissions/acerpo/index.html Outdated Show resolved Hide resolved
submissions/acerpo/index.html Outdated Show resolved Hide resolved
submissions/acerpo/index.html Outdated Show resolved Hide resolved
submissions/acerpo/style/style.css Outdated Show resolved Hide resolved
submissions/acerpo/style/style.css Outdated Show resolved Hide resolved
submissions/acerpo/style/style.css Outdated Show resolved Hide resolved
@Acerpo Acerpo requested a review from A-Ostrovnyy July 29, 2022 17:42
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more issue needs to be done.

submissions/acerpo/index.html Outdated Show resolved Hide resolved
@Acerpo Acerpo requested a review from A-Ostrovnyy July 29, 2022 18:06
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@A-Ostrovnyy A-Ostrovnyy merged commit 4066ce9 into kottans:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants