Arcade game #289

Levi123 · 2022-08-24T12:19:26Z

Object-Oriented JavaScript

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-08-24T14:09:27Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

This PR contains irrelevant files.

You can see this under Files changed tab (you will find a couple of helpful tabs right under the PR title).

Most likely, you added all files from your project, not only required and sufficient code review as instructed in section B123 of submission instructions. Also read an important note therein.

Why we want only few files?

It helps code reviewers to focus on code you authored and have the workspace uncluttered with irrelevant images and transpiled files.
This keeps homeworks repository small.
For example, images add to the weight of the repo and will affect download/upload time for mentors and other students. We all care about others' time.

Please fix this issue by removing irrelevant files and add a comment stating that you did this.

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

github-actions · 2022-08-24T14:09:36Z

discarded (related to Friends App)

github-actions · 2022-08-24T14:09:43Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Frogger Arcade Game -- JS OO exercise check list

Relates to Object-Oriented JavaScript task.

Check-list - definition of done

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

Levi123 · 2022-08-25T15:55:46Z

@A-Ostrovnyy Hello! Can you help me delete irrelevant files?

Levi123 · 2022-08-26T09:16:26Z

@A-Ostrovnyy hello, can you check my code? I'm add main constants and checked my code against the main check-list.

OleksiyRudenko

@Levi123 good job.
Let's take some care of peer developers that will need to collaborate on this project.

OleksiyRudenko · 2022-08-26T17:29:47Z

submissions/Levi123/arcade-game/app.js

+    widthEnemy: 80,
+    heightEnemy: 60,
+    positionX: -100,
+    positionY: [50, 140, 225],


As a peer developer I am tasked to add more rows and more enemies.
I'd like to this in terms or "rows" rather than pixels.
Can we make values calculable from some basic consepts like "row number", "block height" etc?
This also relates to other pixel-based numbers across the code base that are calculable from basic concepts.
As a bonus you will have more accurate positioning of characters on the field.

As a peer developer I am tasked to add more rows and more enemies. I'd like to this in terms or "rows" rather than pixels. Can we make values calculable from some basic consepts like "row number", "block height" etc? This also relates to other pixel-based numbers across the code base that are calculable from basic concepts. As a bonus you will have more accurate positioning of characters on the field.

can you give me your telegram contact?

As a peer developer I am tasked to add more rows and more enemies. I'd like to this in terms or "rows" rather than pixels. Can we make values calculable from some basic consepts like "row number", "block height" etc? This also relates to other pixel-based numbers across the code base that are calculable from basic concepts. As a bonus you will have more accurate positioning of characters on the field.

i refresh my PR and DEMO. I tried to implement line work for enemy creation instead of pixel work

OleksiyRudenko · 2022-08-26T17:30:29Z

submissions/Levi123/arcade-game/app.js

+            setTimeout(() => {
+                this.x = DEFAULT_PLAYER.positionX;
+                this.y = DEFAULT_PLAYER.positionY;
+            }, 300)


What is 300 semantically? I know it is delay. It delays what?

What is 300 semantically? I know it is delay. It delays what?

when person move to waterline, we refresh him position to default. I added delay to smoother animation.

Let the constant name say this somehow

Levi123 · 2022-09-01T18:43:20Z

@OleksiyRudenko Hello, can you review my changes?

OleksiyRudenko

@Levi123 good job!
A few improvements are still needed.

OleksiyRudenko · 2022-09-07T15:46:21Z

submissions/Levi123/arcade-game/app.js

+    if (valueY === 1){
+        enemy = new Enemy(DEFAULT_ENEMY.positionX, firstRowEnemy);
+        allEnemies.push(enemy);
+    }
+
+    if (valueY === 2){
+        enemy = new Enemy(DEFAULT_ENEMY.positionX, secondRowEnemy);
+        allEnemies.push(enemy);
+    }
+
+    if (valueY === 3){
+        enemy = new Enemy(DEFAULT_ENEMY.positionX, thirdRowEnemy);
+        allEnemies.push(enemy);
+    }


As a peer developer I am tasked to add two more rows to the play field.
Can we map valueY into enemy Y position?
Also is valueY is a pixel or field row?
Let the code say that.

Let's also Array#map [1,2,3] directly into allEnemies.

As a peer developer I am tasked to add two more rows to the play field. Can we map valueY into enemy Y position? Also is valueY is a pixel or field row? Let the code say that.

Let's also Array#map [1,2,3] directly into allEnemies.

done

OleksiyRudenko · 2022-09-07T15:47:02Z

submissions/Levi123/arcade-game/app.js

+        if(player.x < this.x + DEFAULT_ENEMY.widthEnemy &&
+            player.x + DEFAULT_ENEMY.widthEnemy > this.x &&
+            player.y < this.y + DEFAULT_ENEMY.heightEnemy &&
+            DEFAULT_ENEMY.heightEnemy + player.y > this.y){
+                player.x = DEFAULT_PLAYER.positionX;
+                player.y = DEFAULT_PLAYER.positionY;


* [ ] classes do not refer to any global variables, like global variable `player`, which is an instance of `Player` class (referring to global constants and globals provided by the gaming platform like `Resources` is OK); Hint: pass `Player` instance as an argument to every enemy

* [ ] classes do not refer to any global variables, like global variable `player`, which is an instance of `Player` class (referring to global constants and globals provided by the gaming platform like `Resources` is OK); Hint: pass `Player` instance as an argument to every enemy

done

OleksiyRudenko

@Levi123 great job!

A-Ostrovnyy added task-Friends irrelevant-files Files not required for the code review task-Frogger and removed task-Friends labels Aug 24, 2022

Levi123 closed this Aug 25, 2022

Levi123 reopened this Aug 25, 2022

New frogger-game app.js

3742a20

Levi123 force-pushed the arcade-game branch from d31b374 to 3742a20 Compare August 25, 2022 16:36

A-Ostrovnyy removed the irrelevant-files Files not required for the code review label Aug 25, 2022

initial main constants for Frogger game

d657e31

OleksiyRudenko requested changes Aug 26, 2022

View reviewed changes

OleksiyRudenko self-assigned this Aug 26, 2022

Change work with pixels to work with rows

6064a59

Levi123 requested a review from OleksiyRudenko August 27, 2022 11:06

OleksiyRudenko requested changes Sep 7, 2022

View reviewed changes

Change way of using player instance

602a1df

Levi123 requested a review from OleksiyRudenko September 12, 2022 22:04

Rename variables

a92d6e6

OleksiyRudenko approved these changes Sep 26, 2022

View reviewed changes

OleksiyRudenko merged commit bc02e89 into kottans:main Sep 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arcade game #289

Arcade game #289

Levi123 commented Aug 24, 2022

github-actions bot commented Aug 24, 2022

github-actions bot commented Aug 24, 2022 •

edited by OleksiyRudenko

Loading

github-actions bot commented Aug 24, 2022

Levi123 commented Aug 25, 2022

Levi123 commented Aug 26, 2022

OleksiyRudenko left a comment

OleksiyRudenko Aug 26, 2022

Levi123 Aug 27, 2022

Levi123 Aug 27, 2022

OleksiyRudenko Aug 26, 2022

Levi123 Aug 26, 2022

OleksiyRudenko Aug 26, 2022

Levi123 commented Sep 1, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 7, 2022

Levi123 Sep 13, 2022

OleksiyRudenko Sep 7, 2022

Levi123 Sep 13, 2022

OleksiyRudenko left a comment

Arcade game #289

Arcade game #289

Conversation

Levi123 commented Aug 24, 2022

Object-Oriented JavaScript

github-actions bot commented Aug 24, 2022

github-actions bot commented Aug 24, 2022 • edited by OleksiyRudenko Loading

github-actions bot commented Aug 24, 2022

Frogger Arcade Game -- JS OO exercise check list

Check-list - definition of done

Levi123 commented Aug 25, 2022

Levi123 commented Aug 26, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Levi123 commented Sep 1, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OleksiyRudenko left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 24, 2022 •

edited by OleksiyRudenko

Loading