Tini Js World

[martthaa]

Tini JS World

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

A Tiny JS World -- (pre-OOP) exercise check list

Relates to Object-Oriented JavaScript task.

Check-list - definition of done

• Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:
  • print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
  • `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods
• Object methods like keys, values, entries shouldn't be used when a particular order is required as these do not guarantee any particular order of keys/values. Same refers to for...of and for...in when applied to objects.
  Hint: List explicitly the properties used to form an object presentation string.
• Men and women belong to the same biological species.
• ES6 class or prototype-based OO syntax aren't used.

Universal recommendations:

• Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
• Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
• Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[OleksiyRudenko]

Deleting code of past tasks may lead to... their deletion from the repo.
It is recommended that you revisit contribution instructions and follow them. It is important to create a branch for the new task when on main. There is a good reason for that

[martthaa]

when I add a new task, I create a new branch (I don't write anything on the main page)
git checkout -b
...make changes....
git add .
git commit -m " "
git push --set-upstream origin
please tell me what i can do wrong

[OleksiyRudenko]

when I add a new task, I create a new branch (I don't write anything on the main page)
git checkout -b
...make changes....
git add .
git commit -m " "
git push --set-upstream origin
please tell me what i can do wrong

You may have committed directly to your fork's main at some point or mixed the order of branches when merging.

Looks like this is where it happened.

You need to re-sync your fork's main with original homerworks repo main. Check this for resolution guidelines (Довідкові матеріали та усунення проблем)

[OleksiyRudenko]

@martthaa good job!
Please double check your code against the bot's message.
At least one requirement is not met.

P.S. Also make sure you fix your fork. The PR looks polluted with unrelated commits.

[OleksiyRudenko]

@martthaa well done!