oop-exercise #349

hisbvdis · 2022-08-29T14:19:42Z

oop-exercise

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-08-29T15:21:33Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

A Tiny JS World -- OOP exercise check list

Relates to A Tiny JS World OOP exercise.

Check-list - definition of done

Minimal requirements to meet:

Optional level up (not required to implement):

Friends list is a list of objects refs rather than names (strings)
Cat-woman class is built employing composition rather than inheritance only

Bonus:

toString magic method; when implemented print(inhabitant) does the job as .toString is called implicitly
this.constructor.name; when used for output then no need to store species property

Helpful resources:

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

OleksiyRudenko

@hisbvdis quite a decent job.
Let's make it OOP/SOLID compliant.

OleksiyRudenko · 2022-09-20T18:25:50Z

submissions/hisbvdis/oop-exercise/index.js

+    this.props = [
+      { prop: "species", preface: "I am a" },
+      { prop: "name", preface: "My name is" },
+      { prop: "gender", preface: "I am a" },
+      { prop: "saying", preface: "I can say —" },
+      { prop: "legs", preface: "I have legs:" },
+    ];
+  }
+
+  getProps() {
+    return this.props
+      .map(({ prop, preface }) => `${preface} ${this[prop]}`)
+      .join("; ");
+  }


Nice solution to handle props and extra wording for them!

OleksiyRudenko · 2022-09-20T18:30:22Z

submissions/hisbvdis/oop-exercise/index.js

+  constructor(name, gender, saying) {
+    super("human", name, gender, saying, 2);
+    this.hands = 2;
+    this.props = this.props.concat({prop: "hands", preface: "I have hands:"});


(1) ES6 offers a different pattern for object literal extension:

obj = {...obj, ...extraProps, ...{yetAnotherProp1: 1, yetAnotherProp2: 2}}

(2) The matter is that class should handle on its own the properties it owns immediately.
There should be good reasons to delegate handling to the base class. There are no such reasons in this task.
Use method overloading and explicit call to an inherited version of the method via extended super API.
Try to keep the elegancy of property-name/preface approach.

(1) ES6 offers a different pattern for object literal extension:

obj = {...obj, ...extraProps, ...{yetAnotherProp1: 1, yetAnotherProp2: 2}}

Коммит: 7f1b42f

(2)...
Use method overloading and explicit call to an inherited version of the method via extended super API

Не очень хорошо понял этот момент.
Постарался сделать так, как понял.
Проверил через console.log() — при создании экземпляров вроде вызывается дочерний метод.

Коммит: 5aa89e8

You need to spread an object even if it consists of a single entry (key+prop) for this to work. Check the examples above.

(2)...
Use method overloading and explicit call to an inherited version of the method via extended super API

Не очень хорошо понял этот момент. Постарался сделать так, как понял. Проверил через console.log() — при создании экземпляров вроде вызывается дочерний метод.

Коммит: 5aa89e8

Yes, and it can call inherited version via super.methodName and add anything on top of that to build required outcome.

(2)...
Use method overloading and explicit call to an inherited version of the method via extended super API

Не очень хорошо понял этот момент. Постарался сделать так, как понял. Проверил через console.log() — при создании экземпляров вроде вызывается дочерний метод.
Коммит: 5aa89e8

Yes, and it can call inherited version via super.methodName and add anything on top of that to build required outcome.

@OleksiyRudenko ,

Из фразы and add anything on top of that to build required outcome я понял, что метод дочернего класса должен как-то изменить (дополнить) this.props родительского класса и вывести их.

К сожалению, приходится гадать.

Может изменять this.props нужно в дочернем методе?

Коммит: ca97d8d

P.S. Может Вы подумали, что у меня this.props — это объект?
Yes, that was my mistake. Your code is correct in these regards.

Из фразы and add anything on top of that to build required outcome я понял, что метод дочернего класса должен как-то изменить (дополнить) this.props родительского класса и вывести их.

Rather add. Changing properties that a class doesn't own immediately is in general a bad practice.
In this specific case changed props property will not be used by the child class. Instead the base class will handle child's property (to create an output string) it knows nothing and shouldn't know nothing about, implicitly extending base class functionality. Extension should only work one way: parent to child in all regards.

Imagine we want to change how hands are reprsented internally (e.g. we want to store an object denoting count of left and right hands instead of simple number), still output would be a simple count of all hands. If we do this change we then are forced to change the base class (conversion of hands property into a number of hands). This breaks encapsulation and OOP principles. Besides we may not be allowed to change the base class at all.
So, a that owns a property should handle it on its own, end to end. Child classes may borrow (via inheritance or explicit calls of inherited versions) anything from base classes chain, but never from child to any of parents in the inheritance chain.

@OleksiyRudenko ,

Может так?
Я Вызываю родительский метод и дополняю его данными из дочернего класса.

P.S. Мне очень жаль, что я не могу понять задачу. Видимо, не хватает понимания ООП.

Коммит: ce36f35

OleksiyRudenko · 2022-09-20T18:30:42Z

submissions/hisbvdis/oop-exercise/index.js

+class Animal extends Creature {
+  constructor(species, name, gender, saying) {
+    super(species, name, gender, saying);
+    this.species = species;


Да, действительно.
Значение из конструктора сразу идёт в super()
Удалил лишнюю строку
Коммит: db1853d

OleksiyRudenko · 2022-09-20T18:31:23Z

submissions/hisbvdis/oop-exercise/index.js

+const woman = new Woman("Bella", "female");
+const man = new Man("Vasya", "male");


Add 3 more humans.
Allow humans to have unique saying.

Коммит: 832570d

…r API

OleksiyRudenko

@hisbvdis well done!
Let's polish it. Also read through your code to check if anything else should be fixed.

OleksiyRudenko · 2022-09-26T22:25:23Z

submissions/hisbvdis/oop-exercise/index.js

+    super(species, name, gender, saying);
+    this.legs = 4;


Classes shouldn't assign values to properties they do not own.
Besides Creature's constructor has parameter for this.

Исправил

Коммит: a20d954

hisbvdis · 2022-09-27T13:14:05Z

Let's polish it

Исправил последовательность присваивания свойств, чтобы совпадало с последовательностью в конструкторе

Коммит: e0d6492

Also read through your code to check if anything else should be fixed

Кроме перестановки последовательности строк с присваиванием свойств больше ничего не нашёл

OleksiyRudenko

@hisbvdis great job!

hisbvdis added 2 commits August 29, 2022 17:18

oop-exercise

4eb84b1

Join symbol

0381bc2

OleksiyRudenko added the task-TJSW-OOP label Aug 29, 2022

Added props array to guarantee particular order

6d84977

OleksiyRudenko requested changes Sep 20, 2022

View reviewed changes

hisbvdis added 4 commits September 20, 2022 21:48

Removed excess property definition

db1853d

unique saying for human

832570d

different pattern for object literal extension

7f1b42f

explicit call to an inherited version of the method via extended supe…

5aa89e8

…r API

hisbvdis requested a review from OleksiyRudenko September 20, 2022 19:38

hisbvdis added 2 commits September 21, 2022 13:13

Inherited class method changes this.props

ca97d8d

Call parent method and add child prop

ce36f35

OleksiyRudenko requested changes Sep 26, 2022

View reviewed changes

hisbvdis added 2 commits September 27, 2022 16:09

Property assignment

a20d954

Code polishing

e0d6492

hisbvdis requested a review from OleksiyRudenko September 27, 2022 13:18

OleksiyRudenko approved these changes Sep 27, 2022

View reviewed changes

OleksiyRudenko merged commit b5edb70 into kottans:main Sep 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

oop-exercise #349

oop-exercise #349

hisbvdis commented Aug 29, 2022

github-actions bot commented Aug 29, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 20, 2022

OleksiyRudenko Sep 20, 2022

hisbvdis Sep 20, 2022

hisbvdis Sep 20, 2022 •

edited

Loading

OleksiyRudenko Sep 20, 2022

OleksiyRudenko Sep 20, 2022

hisbvdis Sep 21, 2022

OleksiyRudenko Sep 21, 2022

OleksiyRudenko Sep 21, 2022

OleksiyRudenko Sep 21, 2022

hisbvdis Sep 21, 2022

OleksiyRudenko Sep 20, 2022

hisbvdis Sep 20, 2022

OleksiyRudenko Sep 20, 2022

hisbvdis Sep 20, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 26, 2022

hisbvdis Sep 27, 2022

hisbvdis commented Sep 27, 2022 •

edited

Loading

OleksiyRudenko left a comment

		const woman = new Woman("Bella", "female");
		const man = new Man("Vasya", "male");

oop-exercise #349

oop-exercise #349

Conversation

hisbvdis commented Aug 29, 2022

oop-exercise

github-actions bot commented Aug 29, 2022

A Tiny JS World -- OOP exercise check list

Check-list - definition of done

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hisbvdis Sep 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hisbvdis commented Sep 27, 2022 • edited Loading

OleksiyRudenko left a comment

Choose a reason for hiding this comment

hisbvdis Sep 20, 2022 •

edited

Loading

hisbvdis commented Sep 27, 2022 •

edited

Loading