a-tiny-js-world-OOP

[NadiaVorontsova]

A-tiny-js-world-OOP

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

A Tiny JS World -- (pre-OOP) exercise check list

Relates to Object-Oriented JavaScript task.

Check-list - definition of done

• Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:
  • print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
  • `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods
• Object methods like keys, values, entries shouldn't be used when a particular order is required as these do not guarantee any particular order of keys/values. Same refers to for...of and for...in when applied to objects.
  Hint: List explicitly the properties used to form an object presentation string.
• Men and women belong to the same biological species.
• ES6 class or prototype-based OO syntax aren't used.

Universal recommendations:

• Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
• Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
• Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[NadiaVorontsova]

I have finished self-checks

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements based on the most common mistakes as well as both basic and advanced requirements from the original task.

Universal recommendations:

• Make sure your code follows General Requirements
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[OleksiyRudenko]

@NadiaVorontsova great job!
Let's take a bit of care of our peer developers that may be tasked to add 100's of men and women.

[OleksiyRudenko]

WHy do we want users to specify gender when creating men and women?

[NadiaVorontsova]

oops it was by accident. I changed it!

[OleksiyRudenko]

Not required to implement here. Just an idea for one of possible ways to add readability for long strings.

[
  "text",
  this.property,
  "more text",
  this.anotherProperty,
].join("; ");

[NadiaVorontsova]

Thanks for this example. I used it)

[OleksiyRudenko]

@NadiaVorontsova well done.
There is yet some room for improvement and discovery.

[OleksiyRudenko]

What if we could rename this method as printInhabitant? Same refers to printAnimal.
We probably would not need separate lists for people and animals at the end of the code.

There is a problem -- the method will try to call itself in an endless loop under current implementation due to this.printInhabitant.

See how super can help you out.

[NadiaVorontsova]

I did it) cool

[OleksiyRudenko]

@NadiaVorontsova great job done!

[NadiaVorontsova]

@NadiaVorontsova great job done!

Thank you)