-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a-tiny-js-world #364
Conversation
Hey! Congratulations on your PR! 😎😎😎 Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code. Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate. If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat. When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly. Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒 A Tiny JS World -- (pre-OOP) exercise check listRelates to Object-Oriented JavaScript task. Check-list - definition of done
Universal recommendations:
Also take a note of the requirements above and follow them in all your future projects. By the way, you may proceed to the next task before this one is reviewed and merged. Sincerely yours, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, let's make some changes to your code. First of all, your demo doesn't work, fix it, please.
Secondly, check the comments below.
species: "human", | ||
name: "Tom", | ||
gender: "male", | ||
legs: 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4-legged humans? Something new.
gender: "female", | ||
legs: 4, | ||
hands: 0, | ||
saying: cat.saying, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if you change what the cat is saying?
saying: "Have a good day!", | ||
}; | ||
const catWoman = { | ||
species: "hulf-human", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
half
const arr = [dog, cat, man, woman, catWoman]; | ||
// ... other objects ... | ||
arr.forEach((element) => { | ||
print(Object.values(element).join(';')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task specifically states not to use Object.values
and similar methods.
saying: cat.saying, | ||
}; | ||
const arr = [dog, cat, man, woman, catWoman]; | ||
// ... other objects ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other objects?
hands: 0, | ||
saying: cat.saying, | ||
}; | ||
const arr = [dog, cat, man, woman, catWoman]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use such broad names, especially don't use data types in variable names. Something like inhabitants
should work best. It states what kind of data is in the array and since it's plural it suggests that it is an array.
@artem-trubin check my changes, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your demo shows nothing and it has an error in the console. Please fix it before asking for another review.
@artem-trubin I corrected my mistakes, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
tiny-js-world
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.