Tiny js world #375

VladimirRutskiy · 2022-08-31T15:47:44Z

OOP exercise

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-08-31T15:56:27Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

A Tiny JS World -- (pre-OOP) exercise check list

Relates to Object-Oriented JavaScript task.

Check-list - definition of done

Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:
- print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
- `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods
Object methods like keys, values, entries shouldn't be used when a particular order is required as these do not guarantee any particular order of keys/values. Same refers to for...of and for...in when applied to objects.
Hint: List explicitly the properties used to form an object presentation string.
Men and women belong to the same biological species.
ES6 class or prototype-based OO syntax aren't used.

Universal recommendations:

Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

VladimirRutskiy · 2022-08-31T16:00:48Z

i have completed self-checks

OleksiyRudenko · 2022-09-07T14:19:40Z

@VladimirRutskiy
I am confused: is it code for TJSW or for OOP Exercise?

VladimirRutskiy · 2022-09-10T09:11:43Z

@OleksiyRudenko It's code for "10. OOP exercise - practice from Advanced Topics list " task

github-actions · 2022-09-12T16:11:47Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements based on the most common mistakes as well as both basic and advanced requirements from the original task.

Universal recommendations:

Make sure your code follows General Requirements
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

yaripey

Hi! I don't see any code that should create instances of your classes or print their info. It seems that this file is incomplete. Can you fix this, please?

VladimirRutskiy · 2022-09-13T15:34:28Z

@artem-trubin I'm so sorry. I didn't notice that the file was partly fill

yaripey

Hey, nice work. Let's make it better. See the comments below.

yaripey · 2022-09-15T15:29:25Z

submissions/VolodymyrRutskyi/tiny-js-world/index.js

+}
+
+class Human extends Inhabitant{
+   constructor (species, name, gender, saying){


Are you sure a Human needs a species here? A human can only be human, isn't it?

yaripey · 2022-09-15T15:30:35Z

submissions/VolodymyrRutskyi/tiny-js-world/index.js

+}
+class Woman extends Human{
+   constructor(name, gender, saying){
+      super('woman', name, gender, saying)


A woman can only be female, so there's no need to ask for a gender in the constructor here.

VladimirRutskiy · 2022-09-17T10:39:16Z

@artem-trubin Thank you. I fixed all remarks

yaripey

Good job!

OleksiyRudenko

@VladimirRutskiy very well done!
Although need to improve it for the sake of OOP compliance, which in its turn will make code maintainable and extensible, concerns will be separated across classes.

OleksiyRudenko · 2022-09-20T07:34:19Z

submissions/VolodymyrRutskyi/tiny-js-world/index.js

+   constructor (name, gender, saying){
+      super('human', name, gender, 2, saying);
+      this.hands = 2;
+      this.props = [...this.props, 'hands']


It is generally a bad practice to directly change properties that are owned by the base class.
Every class should handle its own properties i.e. encapsulate both properties and behaviour.
The same refers to Inhabitant#showProps.
Let every class handle properties it owns.
Use method overloading to provide seamless user experience.
You will benefit from explicit call to inherited version of the methos via super.
Task and original project materials offer links to the articles that you will find helpful.

I have fixed

OleksiyRudenko

@VladimirRutskiy make a step back.
legs were right where they belonged.
My comment referred to this.prop direct assignment in a child class.
Actually, you do not need this.props at all. It is brought from pre-OOP version obviously, and there it was a workaround. OOP paradigm helps to avoid that sort of workarounds.
Let's restore previous version. I will explain some theory on that and we will rather merge that previous version. It was better.

yaripey

Good job!

VladimirRutskiy and others added 3 commits August 23, 2022 17:44

First approach

b7af201

Improved code according to OOP

f9e8889

Update index.js

86bc054

A-Ostrovnyy added the task-TJSW label Aug 31, 2022

Merge branch 'main' into Tiny_js_world

ea7c491

yaripey added task-TJSW-OOP and removed task-TJSW labels Sep 12, 2022

yaripey self-assigned this Sep 12, 2022

yaripey requested changes Sep 12, 2022

View reviewed changes

VladimirRutskiy and others added 2 commits September 13, 2022 18:30

Added full index file

4327e3a

Update index.js

c0a923e

VladimirRutskiy requested a review from yaripey September 13, 2022 15:34

yaripey requested changes Sep 15, 2022

View reviewed changes

VladimirRutskiy added 2 commits September 17, 2022 13:28

Fixed some remarks

6a217ba

Fixed some remarks

1d2a2c3

VladimirRutskiy requested a review from yaripey September 17, 2022 10:39

yaripey approved these changes Sep 17, 2022

View reviewed changes

OleksiyRudenko requested changes Sep 20, 2022

View reviewed changes

VladimirRutskiy and others added 4 commits September 28, 2022 19:41

Fixed some remarks

2b9e2ef

Update index.js

32370ee

fixed some remarks

e0fb4ff

fixes some mistakes

c61dba5

OleksiyRudenko requested changes Sep 29, 2022

View reviewed changes

yaripey approved these changes Oct 1, 2022

View reviewed changes

yaripey merged commit b5bfc84 into kottans:main Oct 1, 2022

OleksiyRudenko added the Stage0.1 label Oct 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tiny js world #375

Tiny js world #375

VladimirRutskiy commented Aug 31, 2022

github-actions bot commented Aug 31, 2022

VladimirRutskiy commented Aug 31, 2022

OleksiyRudenko commented Sep 7, 2022

VladimirRutskiy commented Sep 10, 2022

github-actions bot commented Sep 12, 2022

yaripey left a comment

VladimirRutskiy commented Sep 13, 2022

yaripey left a comment

yaripey Sep 15, 2022

yaripey Sep 15, 2022

VladimirRutskiy commented Sep 17, 2022

yaripey left a comment

OleksiyRudenko left a comment

OleksiyRudenko Sep 20, 2022

VladimirRutskiy Sep 28, 2022

OleksiyRudenko left a comment

yaripey left a comment

Tiny js world #375

Tiny js world #375

Conversation

VladimirRutskiy commented Aug 31, 2022

OOP exercise

github-actions bot commented Aug 31, 2022

A Tiny JS World -- (pre-OOP) exercise check list

Check-list - definition of done

VladimirRutskiy commented Aug 31, 2022

OleksiyRudenko commented Sep 7, 2022

VladimirRutskiy commented Sep 10, 2022

github-actions bot commented Sep 12, 2022

yaripey left a comment

Choose a reason for hiding this comment

VladimirRutskiy commented Sep 13, 2022

yaripey left a comment

Choose a reason for hiding this comment

yaripey Sep 15, 2022

Choose a reason for hiding this comment

yaripey Sep 15, 2022

Choose a reason for hiding this comment

VladimirRutskiy commented Sep 17, 2022

yaripey left a comment

Choose a reason for hiding this comment

OleksiyRudenko left a comment

Choose a reason for hiding this comment

OleksiyRudenko Sep 20, 2022

Choose a reason for hiding this comment

VladimirRutskiy Sep 28, 2022

Choose a reason for hiding this comment

OleksiyRudenko left a comment

Choose a reason for hiding this comment

yaripey left a comment

Choose a reason for hiding this comment