Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM task #388

Merged
merged 4 commits into from
Sep 13, 2022
Merged

DOM task #388

merged 4 commits into from
Sep 13, 2022

Conversation

franchukv
Copy link
Contributor

DOM

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes

Universal recommendations:

  • Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
  • Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
  • Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
  • Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

@franchukv franchukv changed the title Dom api task DOM task Sep 2, 2022
@franchukv
Copy link
Contributor Author

Self-check done.

@A-Ostrovnyy A-Ostrovnyy added the self-check-done Student confirmed that self-checks against requirements/common-mistakes are done label Sep 12, 2022
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
It will be nice to highlight selected element in navigation.

submissions/franchukv/dom-api/index.html Outdated Show resolved Hide resolved
submissions/franchukv/dom-api/index.html Outdated Show resolved Hide resolved
submissions/franchukv/dom-api/index.html Outdated Show resolved Hide resolved
submissions/franchukv/dom-api/index.html Outdated Show resolved Hide resolved
submissions/franchukv/dom-api/script.js Outdated Show resolved Hide resolved
submissions/franchukv/dom-api/script.js Outdated Show resolved Hide resolved
submissions/franchukv/dom-api/script.js Outdated Show resolved Hide resolved
@A-Ostrovnyy A-Ostrovnyy self-assigned this Sep 12, 2022
Replaced not-interactive HTML tags to interactives.
Rewrote a "createContent" function using template string.
Rewrote a "createNavigation" function to avoid reflow and repaint for every element of navigation.
Added possibility to user to visually track current page in side-menu.
Rewrote a lot of css styles for correct responsive view and user experience.
@franchukv
Copy link
Contributor Author

Done all recommendations from latest review.

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, for the future, don't resolve comments, it's for authors)

@A-Ostrovnyy A-Ostrovnyy merged commit 83d5542 into kottans:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
self-check-done Student confirmed that self-checks against requirements/common-mistakes are done task-DOM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants