completed first approach

[sofiichuk]

a tiny js world: first approach

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes listed/linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

A Tiny JS World -- (pre-OOP) exercise check list

Relates to Object-Oriented JavaScript task.

Check-list - definition of done

• Code is DRY, which means that whenever you see a pattern in your code those should be eliminated as much as possible. Examples:
  • print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
  • `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods
• Object methods like keys, values, entries shouldn't be used when a particular order is required as these do not guarantee any particular order of keys/values. Same refers to for...of and for...in when applied to objects.
  Hint: List explicitly the properties used to form an object presentation string.
• Men and women belong to the same biological species.
• ES6 class or prototype-based OO syntax aren't used.

Universal recommendations:

• Give variables and functions meaningful names. Avoid generic names like item, element, key, object, array or their variations. Exception: helper functions that are specifically and intentionally designed to be multipurpose.
• Function names should start with a verb as they denote actions; variables are normally nouns; boolean variables/functions start with is, does, has etc; variable containing multiple entities and functions returning lists contain entity name in plural form.
• Have consistent code style and formatting. Employ Prettier to do all dirty work for you.
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

Also take a note of the requirements above and follow them in all your future projects.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[sofiichuk]

checked

[yaripey]

Hey, what happened to your Catwoman O? Why is she so undefined. Define her or something. Jokes aside, there is a problem with her saying. Task asks you to make it so Catwoman says the same that cat says ANYTIME. But in your current implementation changing the cat's saying doesn't change Catwoman's one, does it?

[sofiichuk]

hi!

saying: cat.saying does work indeed)
you could check it (in the console) here: https://codepen.io/sofiichuk/pen/ZEopPxW?editors=0010

although i could've changed it by the means of inheritance (as i did here - https://github.com/sofiichuk/a-tiny-JS-world/blob/OOP-exercise/index.js).
but the goal was - to do it without learning OOP approach (i had been unaware of that moment) - and so did i.

do i have to change anything yet?

[yaripey]

Well yes, your catwoman does say what the cat initially says, but that's why I marked ANYTIME in my comment. Consider this:

const cat = { saying: "First test" };
const catwoman = { saying: cat.saying };
console.log(catwoman.saying) // this will be "First test"
cat.saying = "Second test";
console.log(catwoman.saying) // this should be "Second test", but with your implementation, it will still be "First test"

So you need to find a way to connect those values in some way. And yes, for the means of this task, without using classes syntax.

[sofiichuk]

spent so much time...
why hadn't you told me how to solve it?!
fixed that finally

[yaripey]

GJ, it works, but please check my comment below and keep it in mind in the future.

[yaripey]

This is the second time I see Object.setPrototypeOf, did anyone tell you to use it? Specs say it is a very slow method and there is an alternative - Object.create(). Or you could've used bind. Anyway, keep these in mind.

[sofiichuk]

at first i tried to transform cat.saying to an object/array to pass it by reference;
then i tried to combine cat and catwoman props using object.assign;
i failed with both;
then i found out people handle stuff like this with a _proto_;
but i had already known of _proto_ as a (kind of) method not recommended to use in explicit way;
so i continued searchin for smth similar as a substitution;
nth-google-request was "set prototype" and it led to setPrototype;
(and now i see it's no better than using _proto_ - but afterwards)

[yaripey]

Got it, nice research)