Task js_oop (Frogger game) #456

Mifaresss · 2022-09-06T11:19:15Z

JS_oop (Frogger game)

The code is submitted in a dedicated feature branch. Only code files are submitted.

Please, review.

github-actions · 2022-09-06T11:25:12Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements

Universal recommendations:

Make sure your code follows General Requirements
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

Mifaresss · 2022-09-06T13:04:55Z

I went through all the points in advance

OleksiyRudenko

@Mifaresss please post requirements posted/linked by bot.
Go through them, mark those that are met, fix code accrodnigly.
If any requirement is not clear feel free asking questions in Students' chat.

OleksiyRudenko · 2022-09-20T16:58:27Z

submissions/Mifaresss/task_js_oop/app.js

+         if (player.x < this.x + 77 && player.x + 77 > this.x && player.y < this.y + 66 && player.y + 66 > this.y) {
+            player.x = player.startX;
+            player.y = player.startY;


Requirements posted/linked by bot address specifically issue we have in this fragment.
Identify it, post it here as a comment and fix code accordingly.

OleksiyRudenko · 2022-09-20T16:59:29Z

submissions/Mifaresss/task_js_oop/app.js

+let enemy1 = new Enemies(enemyConfig[0].y, enemyConfig[0].speedX);
+let enemy2 = new Enemies(enemyConfig[1].y, enemyConfig[1].speedX);
+let enemy3 = new Enemies(enemyConfig[2].y, enemyConfig[2].speedX);


Requirements posted/linked by bot address specifically issue we have in this fragment.
Identify it, post it here as a comment and fix code accordingly.
As a peer developer I am tasked to add 50 more enemies. I want to make as little changes as possible in order to achieve this.

OleksiyRudenko · 2022-09-20T17:00:13Z

submissions/Mifaresss/task_js_oop/app.js

+      if (this.x > 500) this.x = -100;
+      this.checkClash();
+   }
+   checkClash() {
+         if (player.x < this.x + 77 && player.x + 77 > this.x && player.y < this.y + 66 && player.y + 66 > this.y) {


Requirements with regards to magic numbers are not met.

Mifaresss · 2022-09-20T17:31:37Z

Sorry, I kind of remember you saying you omit the requirement to not use the class syntax. Or I misunderstood and it is necessary to write on prototypes?

OleksiyRudenko · 2022-09-20T18:57:44Z

Sorry, I kind of remember you saying you omit the requirement to not use the class syntax. Or I misunderstood and it is necessary to write on prototypes?

Skip this one, np.

Mifaresss · 2022-09-21T18:42:13Z

I don’t know what was in my head when I did a self-test .... apparently, I was intoxicated with the result or just a fool))
In the end, I decided to redo everything, so that it was "as it should be."
I'll try to be quick)

OleksiyRudenko

@Mifaresss very well done!
Let's polish it. One important fix required. Others would be negligible, but since we are here anyway...

OleksiyRudenko · 2022-09-26T11:11:37Z

submissions/Mifaresss/task_js_oop/app.js

+const Enemy = function (x, y, sprite) {
+	Character.call(this, x, y, sprite)
+	this.speed = getRandomSpeed(ENEMIES_SPEED.min, ENEMIES_SPEED.max);
+	this.player = player;


See item 4.iii of the requirements

I don’t understand how to fix this( I asked a question in the chat just on this point. And they told me that it was so right ... Can you explain this point in more detail?

Or to make it right, I just need to add the player to the enemy class constructor?

Might work. For example, you pass x to the Player constructor instead of using a global variable e.g. playerX. Same approach.

OleksiyRudenko · 2022-09-26T11:12:37Z

submissions/Mifaresss/task_js_oop/app.js

+const FIELD_WIDTH = CELL_WIDTH * COLUMNS;
+const FIELD_HEIGHT = CELL_HEIGHT * ROWS;
+
+const PLAYER_START_POSITION_X = 202;


Seems like a derivative from another constant.

Did something like this:
const PLAYER_START_POSITION_X = CELL_WIDTH * Math.floor(COLUMNS / 2);

...I hope it's right. Although, to be honest, I don't see much point in this🤔

Looks more like a double of 101.

Might be a different approach, just like you suggested. At least it will autocalculate the X position when number of columns change.

Can I leave it as is?

OleksiyRudenko · 2022-09-26T11:13:05Z

submissions/Mifaresss/task_js_oop/app.js

+
+const PLAYER_START_POSITION_X = 202;
+const PLAYER_START_POSITION_Y = 385;
+const PLAYER_STEP_LENGTH_X = 101;


Seems like we can "syc up" this with another constant.

OleksiyRudenko · 2022-09-26T11:14:56Z

submissions/Mifaresss/task_js_oop/app.js

+	first: 60,
+	second: 143,
+	third: 226,


Hmmm... JS god gave us arrays so that we do not need to write anything alike array[first], array[second]... array[fiftySixth]

OleksiyRudenko

@Mifaresss perfectly well!

Mifaresss · 2022-09-26T16:55:20Z

Thanks))))

Task js_oop (Frogger game) complete

993cdf8

OleksiyRudenko added the task-Frogger label Sep 6, 2022

OleksiyRudenko added the self-check-done Student confirmed that self-checks against requirements/common-mistakes are done label Sep 20, 2022

OleksiyRudenko requested changes Sep 20, 2022

View reviewed changes

OleksiyRudenko self-assigned this Sep 20, 2022

The work has been redone to meet the requirements

051ad91

Mifaresss requested a review from OleksiyRudenko September 22, 2022 10:40

OleksiyRudenko requested changes Sep 26, 2022

View reviewed changes

Fixed according to the mentor's comments

25f4fed

Mifaresss requested a review from OleksiyRudenko September 26, 2022 12:46

OleksiyRudenko approved these changes Sep 26, 2022

View reviewed changes

OleksiyRudenko merged commit 576384a into kottans:main Sep 26, 2022

Mifaresss deleted the task_js_oop branch September 26, 2022 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Task js_oop (Frogger game) #456

Task js_oop (Frogger game) #456

Mifaresss commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

Mifaresss commented Sep 6, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 20, 2022

Mifaresss Sep 22, 2022

OleksiyRudenko Sep 20, 2022

Mifaresss Sep 22, 2022

OleksiyRudenko Sep 20, 2022

Mifaresss Sep 22, 2022

Mifaresss commented Sep 20, 2022

OleksiyRudenko commented Sep 20, 2022

Mifaresss commented Sep 21, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 26, 2022

Mifaresss Sep 26, 2022 •

edited

Loading

Mifaresss Sep 26, 2022

OleksiyRudenko Sep 26, 2022

OleksiyRudenko Sep 26, 2022

Mifaresss Sep 26, 2022 •

edited

Loading

OleksiyRudenko Sep 26, 2022 •

edited

Loading

Mifaresss Sep 26, 2022

OleksiyRudenko Sep 26, 2022

Mifaresss Sep 26, 2022

OleksiyRudenko Sep 26, 2022

Mifaresss Sep 26, 2022

OleksiyRudenko left a comment

Mifaresss commented Sep 26, 2022

Task js_oop (Frogger game) #456

Task js_oop (Frogger game) #456

Conversation

Mifaresss commented Sep 6, 2022

JS_oop (Frogger game)

github-actions bot commented Sep 6, 2022

Mifaresss commented Sep 6, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mifaresss commented Sep 20, 2022

OleksiyRudenko commented Sep 20, 2022

Mifaresss commented Sep 21, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mifaresss Sep 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mifaresss Sep 26, 2022 • edited Loading

Choose a reason for hiding this comment

OleksiyRudenko Sep 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Mifaresss commented Sep 26, 2022

Mifaresss Sep 26, 2022 •

edited

Loading

Mifaresss Sep 26, 2022 •

edited

Loading

OleksiyRudenko Sep 26, 2022 •

edited

Loading