html-css-popup #48
Merged
html-css-popup #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannaSyn
requested changes
Aug 2, 2022
| </li> | ||
| <li class="popap__item"> | ||
| <a href="#" class="popap__link"> | ||
| <img class="popap__link-icon" src="icons/mail.png" alt="icon"> |
There was a problem hiding this comment.
For icons it's better set an empty alt attribute, read more here
| <li class="navbar__item"> | ||
| <a href="#" class="navbar__link">Images</a> | ||
| </li> | ||
| <li class="navbar__item popap"> |
There was a problem hiding this comment.
Please, replace popap with popup everywhere in project, it is a typo.
| <img class="popap__trigger-icon" src="icons/popup-button.png" alt="icon"> | ||
| </label> | ||
| <div class="popap__body"> | ||
| <input class="popap__input-more" id="popap__more" type="checkbox"> |
There was a problem hiding this comment.
You need move this input because when you navigate with tab, focus should be at icons first, and on More after icons.
Added attribute tabindex because when you navigate with tab, focus should be at icons first, and on More after icons.
|
I fixed all. Please, check the changes. |
|
Great work! Almost done |
Took away the opportunity to interact with "hidden" icons when I navigate with a tab.
|
I fixed this bug. Please, check the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML і CSS практика: Hooli-style Popup
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.