classic frogger game done #500

andysmokk · 2022-09-09T11:39:37Z

Object-Oriented JavaScript (Classic Frogger Game)

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-09-09T11:48:31Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements

Universal recommendations:

Make sure your code follows General Requirements
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

andysmokk · 2022-09-09T12:45:57Z

Self-check complete. Thanks:v:.

OleksiyRudenko

@andysmokk good job!
Yet one important thing needs to be fixed. Constants definition is secondary and less critical but fix it as well.

OleksiyRudenko · 2022-09-20T16:19:02Z

submissions/andysmokk/classic-frogger-game/app.js

+    player.y < this.y + 50 &&
+    player.y + 50 > this.y &&
+    player.x < this.x + 75 &&
+    player.x + 75 > this.x


Please find a requirement among those listed/linked by bot, post it here as a comment and also fix code accordingly.

Classes do not refer to any global variables, like global variable player, which is an instance of Player class (referring to global constants and globals provided by the gaming platform like Resources is OK); Hint: pass instance of a game object (or objects) as an argument to other game objects they need to interact with.

OleksiyRudenko · 2022-09-20T16:20:09Z

submissions/andysmokk/classic-frogger-game/app.js

+const INITIAL_POSITION_PLAYER_X = 203;
+const INITIAL_POSITION_ENEMIES_X = -200;
+const INITIAL_POSITION_ENEMY_ONE_Y = 62;
+const INITIAL_POSITION_ENEMY_TWO_Y = 145;
+const INITIAL_POSITION_ENEMY_THREE_Y = 228;
+const INITIAL_POSITION_PLAYER_Y = 390;


Think of less wordy contants definition.
Requirements provide relevant examples.

andysmokk · 2022-09-22T20:30:25Z

Thank you for the review, and review again please 🙏.

OleksiyRudenko

@andysmokk good job.
Although needs improvement.
You may want to revisit OOP educational materials.

OleksiyRudenko · 2022-09-26T11:32:04Z

submissions/andysmokk/classic-frogger-game/app.js

+const enemyOne = new Enemy(POSITION_ENEMIES_X, POSITION_ENEMY_ONE_Y);
+const enemyTwo = new Enemy(POSITION_ENEMIES_X, POSITION_ENEMY_TWO_Y);
+const enemyThree = new Enemy(POSITION_ENEMIES_X, POSITION_ENEMY_THREE_Y);


Imagine you are tasked to add 10 more enemies.
Make this fragment DRY and number of line of codes not dependent on number of enemies.

OleksiyRudenko · 2022-09-26T11:32:51Z

submissions/andysmokk/classic-frogger-game/app.js

+  player.x = POSITION_PLAYER_X;
+  player.y = POSITION_PLAYER_Y;


Explain, why player.*?

Бо я не уважний. У цьому випадку щоб отримати доступ до даних всередині об'єкта треба використовувати this, а не глобальну змінну. Виправлено.

OleksiyRudenko · 2022-09-26T11:37:29Z

submissions/andysmokk/classic-frogger-game/app.js

+Enemy.prototype.update = function (dt, gamer) {
+  this.x += this.speed * dt;
+
+  if (this.x > 500) {
+    this.x = POSITION_ENEMIES_X;
+    this.speed = this.randomInteger();
+  }
+
+  if (
+    gamer.y < this.y + 50 &&
+    gamer.y + 50 > this.y &&
+    gamer.x < this.x + 75 &&
+    gamer.x + 75 > this.x
+  ) {
+    gamer.initialPositionPlayer();
+  }
+};


This shouldn't work unless you changed the engine.
Please re-do as changing the engine is a no-go here.
Imagine, you are on a commercial project and opt to change shared code when the problem is solvable without doing this.
The requirements contain a hint on how to resolve the issue properly. Just need to read carefully.

andysmokk · 2022-09-30T12:37:29Z

Дуже дякую Вам, я дійсно слабкий в ООП.
Ваші підказки та вказання на помилки дали мені можливість розібратись та зрозуміти ООП краще.

OleksiyRudenko

@andysmokk good job.
Let's polish it.

OleksiyRudenko · 2022-10-02T12:14:50Z

submissions/andysmokk/classic-frogger-game/app.js

+Enemy.prototype.update = function (dt) {
+  this.x += this.speed * dt;
+
+  if (this.x > 500) {


What is 500?

Is the wigth of the playing field. Fixed.

OleksiyRudenko · 2022-10-02T12:15:11Z

submissions/andysmokk/classic-frogger-game/app.js

+    this.user.y < this.y + 50 &&
+    this.user.y + 50 > this.y &&
+    this.user.x < this.x + 75 &&
+    this.user.x + 75 > this.x


What are 50 and 75?

OleksiyRudenko · 2022-10-02T12:16:09Z

submissions/andysmokk/classic-frogger-game/app.js

+
+const player = new Player(POSITION_PLAYER_X, POSITION_PLAYER_Y);
+
+const enemyPositionsY = [62, 145, 228];


What are 62, 145, 228?
As a peer deveoper I am tasked to add the 4th track enemies can run. What would be the number? Can we calculate it based on track number?

Fixed. Added a calculate of function the position Y of enemies.

OleksiyRudenko · 2022-10-02T12:16:29Z

submissions/andysmokk/classic-frogger-game/app.js

+    this.y -= BLOCK_HEIGHT;
+  }
+
+  if (keyPressed === "down" && this.y < 390) {


What is 390?
Is it calculable?

390 is the player`s starting point (axis Y). It is calculable. Fixed

OleksiyRudenko · 2022-10-02T12:16:35Z

submissions/andysmokk/classic-frogger-game/app.js

+    this.x -= BLOCK_WIDTH;
+  }
+
+  if (keyPressed === "right" && this.x < 405) {


What is 405?
Is it calculable?

405 is the end point of the player (axis X). It is calculable. Fixed

andysmokk · 2022-10-03T13:24:36Z

Please review again 😏.

OleksiyRudenko

@andysmokk great job!

andysmokk · 2022-10-05T18:04:24Z

Thank you.

classic frogger game done

d36f35d

OleksiyRudenko added the task-Frogger label Sep 9, 2022

OleksiyRudenko added the self-check-done Student confirmed that self-checks against requirements/common-mistakes are done label Sep 20, 2022

OleksiyRudenko requested changes Sep 20, 2022

View reviewed changes

OleksiyRudenko self-assigned this Sep 20, 2022

refactoring done

3a59b50

andysmokk requested a review from OleksiyRudenko September 22, 2022 20:30

OleksiyRudenko requested changes Sep 26, 2022

View reviewed changes

OleksiyRudenko added the OQ Open Question from reviewer requiring explanation label Sep 26, 2022

corrections after the review

9229690

andysmokk requested a review from OleksiyRudenko September 30, 2022 12:38

OleksiyRudenko added the Stage0.1 label Oct 1, 2022

OleksiyRudenko requested changes Oct 2, 2022

View reviewed changes

refactoring

17e47c5

andysmokk requested a review from OleksiyRudenko October 3, 2022 13:24

OleksiyRudenko approved these changes Oct 5, 2022

View reviewed changes

OleksiyRudenko merged commit 145e196 into kottans:main Oct 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

classic frogger game done #500

classic frogger game done #500

andysmokk commented Sep 9, 2022

github-actions bot commented Sep 9, 2022

andysmokk commented Sep 9, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 20, 2022

andysmokk Sep 22, 2022

OleksiyRudenko Sep 20, 2022

andysmokk Sep 22, 2022 •

edited

Loading

andysmokk commented Sep 22, 2022

OleksiyRudenko left a comment

OleksiyRudenko Sep 26, 2022

andysmokk Sep 30, 2022

OleksiyRudenko Sep 26, 2022

andysmokk Sep 30, 2022 •

edited

Loading

OleksiyRudenko Sep 26, 2022

andysmokk Sep 30, 2022

andysmokk commented Sep 30, 2022

OleksiyRudenko left a comment

OleksiyRudenko Oct 2, 2022

andysmokk Oct 3, 2022

OleksiyRudenko Oct 2, 2022

andysmokk Oct 3, 2022

OleksiyRudenko Oct 2, 2022

andysmokk Oct 3, 2022

OleksiyRudenko Oct 2, 2022

andysmokk Oct 3, 2022 •

edited

Loading

OleksiyRudenko Oct 2, 2022

andysmokk Oct 3, 2022

andysmokk commented Oct 3, 2022

OleksiyRudenko left a comment

andysmokk commented Oct 5, 2022


		const player = new Player(POSITION_PLAYER_X, POSITION_PLAYER_Y);

		const enemyPositionsY = [62, 145, 228];

classic frogger game done #500

classic frogger game done #500

Conversation

andysmokk commented Sep 9, 2022

Object-Oriented JavaScript (Classic Frogger Game)

github-actions bot commented Sep 9, 2022

andysmokk commented Sep 9, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andysmokk Sep 22, 2022 • edited Loading

Choose a reason for hiding this comment

andysmokk commented Sep 22, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andysmokk Sep 30, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andysmokk commented Sep 30, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andysmokk Oct 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andysmokk commented Oct 3, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

andysmokk commented Oct 5, 2022

andysmokk Sep 22, 2022 •

edited

Loading

andysmokk Sep 30, 2022 •

edited

Loading

andysmokk Oct 3, 2022 •

edited

Loading