Object Oriented JavaScript #51
Conversation
…orks into object-oriented-javascript
Minor change: numerical comparison now changed to comprasion with obj property
Minot change: forEach and push methods changed to .map method
|
Little mistake in last commit comment -_- |
|
@Eugene-CG why you close this PR? |
Sorry, I want to delete my comment and click everything I see |
|
To avoid this situation I always use my code editor instead of web interface) don't worry about the same commit message, if you want to change it use |
Already changed :3 |
There was a problem hiding this comment.
@Eugene-CG great job!
A couple of improvements and we are done.
| if (this.y < tileSize.height - charactersSize.charboy) { | ||
| setTimeout(() => { | ||
| alert("You won"); | ||
| this.y = tileSize.height * 4 - charactersSize.charboy; | ||
| this.x = tileSize.width * 2; | ||
| }, 100); | ||
| } |
There was a problem hiding this comment.
The method name is imperative, however the body assumes a condition. This confuses me as a peer developer.
You may want either rename the method or do conditional checks elsewhere where coordinates change happens and let this method just set some coordinates imperatively.
Object oriented javascript
Demo
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.