OOP Exercise #518

unabyband · 2022-09-11T18:23:05Z

OOP Exercise

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

github-actions · 2022-09-11T19:16:30Z

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements based on the most common mistakes as well as both basic and advanced requirements from the original task.

Universal recommendations:

Make sure your code follows General Requirements
Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

unabyband · 2022-09-12T11:59:23Z

I've made self-checking, please review

OleksiyRudenko

@unabyband one of the purposes of the module is to learn something new and also demonstrate a practical grip over this new knowledge.
Also techniques learned earlier still worth re-using.

OleksiyRudenko · 2022-09-26T21:20:00Z

submissions/unabyband/oop_exercise/index.js

+    this.species = species;
+    this.name = name;
+    this.gender = gender;
+    this.limbs = limbs;


Introduce legs and hands and/or paws. In OOP-compliant manner.
Will be happy to see if you mastered OOP - that's the purpose of the module.

OleksiyRudenko · 2022-09-26T21:21:16Z

submissions/unabyband/oop_exercise/index.js

+ all next arguments are indexes of his friends.
+ I know, it's optional, but hoping my solution is not too primitive*/
+
+ function addFriends(...arguments) {


With current signature won't let me know what exactly is expected by this function at call time, without reading the source code.
Code is written for other people.

OleksiyRudenko · 2022-09-26T21:23:01Z

submissions/unabyband/oop_exercise/index.js

+addFriends(0, 3, 7);
+addFriends(1, 4, 5, 6);
+addFriends(2, 5, 6, 9);
+addFriends(3, 0, 7);
+addFriends(4, 1, 5, 6, 8);
+addFriends(5, 2, 6, 9);
+addFriends(8, 4);
+addFriends(9, 1, 2);


The function signature looked like all arguments represent the same role. This example doesn't really give an idea of how to add another friend pack. Are these numbers a sort of ids?
Make it more obvious

Well, I finally give up.
I've tried so many variations how to force this function works as a method of "Inhabitant" class, but it doesn't look possible before I initialize "inhabitants" array.
Perhaps, this function should not be the method of main class. I don't know
Or, maybe lot easier resolve exists and it just unclear for me at this point.
Sorry, I remember that this part of exercise does not necessary
We can put whole objects as elements of each "friends" container only after the initialization of our array not before.

You can call any method after the object initialization. E.g. paul.addFriends([nina, toby, robert])

But in this case, I should totally change the construction of our array, in order the name of inhabitant becomes the name of variable, I guess...

You can extract names (or any other property) when it is needed exactly.
Consider the following example:

function setParents(parents) { this.parents = parents } function getParentsNames() { return this.parents.map(parent => parent.name).join(", ") }

Rule of thumb: extract and transform original data exactly where it is needed.

OleksiyRudenko · 2022-09-26T21:24:09Z

submissions/unabyband/oop_exercise/index.js

+  }
+
+  printInhabitant () {
+    print(`${this.species}; <strong>${this.name}</strong>; ${this.gender}; ${this.limbs.join('; ')}; <em>${this.saying}</em>; ${this.friends ? this.friends.map(elem => elem.name).join(', ') : 'Cats have no friends'}`);


There are Array methods to make code DRYer. An array element can be an expression (or rather a result of expression).

Object methods still do not guarantee order of properties/values.
You could improve exisiting line 22.
Ask Students' chat how it could be improved using Array methods. You will learn yourself and, probably, other students will learn on this example.
You will come across this pattern quite often. Use the opportunity.

I think we speak about toString()... I'll try it

Not really. We speak about [].join and

An array element can be an expression (or rather a result of expression).

Feel free to ask questions

Ok, I think I finally get it, please review again

Could you review it again, please?

unabyband · 2022-09-27T12:06:04Z

Please review again, thank you

OleksiyRudenko

@unabyband
Bring back paws and hands (in OOP way), friends and whatever you just removed from the code.
And try to solve this problems. You will learn something useful that you will be able use in your next projects. You will also understand better certain important concepts on Stage 1.
Do not worry about stage 0 deadline.

unabyband · 2022-09-29T22:49:54Z

I bring back and rewrote addFriends function, and make some fixes, please re-review. Thank you

unabyband · 2022-10-04T07:15:02Z

I've brought legs/hands/paws back, and made some out formatting for greater look at the page.
Also I've wrote (and modified after that) addFriends() function and used "Prettier" for better code look.
Please re-review my work, thanks a lot!

OleksiyRudenko

@unabyband good improvements.
Now need to make the design OOP-compliant.

OleksiyRudenko · 2022-10-05T13:52:14Z

submissions/unabyband/oop_exercise/index.js

+  }
+}
+
+class Animal extends Inhabitant {


In fact, every instance of Animal has property for hands - hands.
OOP helps to design the system of business entities so that they just do not have unnecessary properties.
This is something bigger than just a way to provide default values to the base class.

Also requirement say that inhabitants that do not have something by natural design they do not have any properties for this. OOP helps to build scalable code that doesn't require to change base class when we want to handle something specific to a sub-class.

Make so that only humans have hands in any meaning. Also remember that very class should handle the properties it owns immediately. Do not delegate property handling to parent class (it should be agnostic of any properties a child class may have).

Learning materials cover this topic. Look for Open-Closed principles in SOLID and all of OOP principles.

Well, I've remade printInhabitant method especially for Human class, for printing out "Hands" property.
This way looks less DRY (Even though rewriting methods is one of the OOP-principles).
Please re-review my fixes. Thank you.

…ds" property

unabyband · 2022-10-07T07:50:11Z

Now Base class and Animal subclass don't have any type of "Hands" property, this became exclusively for Human.
Please re-review

OleksiyRudenko

@unabyband quite a decent job.
Let's make it OOP compliant and use mechanics JS OOP syntax offers to write DRY, maintainable and scalable code.

OleksiyRudenko · 2022-10-09T15:19:30Z

submissions/unabyband/oop_exercise/index.js

+    this.friends = friends;
+  }
+
+  printInhabitant() {


(1) Separation of concerns (remember requirements re Frogger?)
This method forms an output and also conducts output.

(2) You may construct arrays from any legal JS expressions. Consider an example below

[ this.propName, `prefix ${this.PropName} suffix`, arrayVariable.join("glue "), condition ? expressionIfTrue : "stringIfFalse", ]

OleksiyRudenko · 2022-10-09T15:20:17Z

submissions/unabyband/oop_exercise/index.js

+  printInhabitant() {
+    const nameToPrint = `<strong>${this.name}</strong>`;
+    const legsToPrint = `On ${this.legs} legs`;
+    const handsToPrint = `Has ${this.hands} hands`;
+    const talkToPrint = `<em>${this.saying}</em>`;
+    const friendsToPrint = this.friends.map((friend) => friend.name).join(", ");


Use method overloading/overriding. This will help to make your code DRY.
Check learning materials and find out what super's extended API can do for you.

…class method

unabyband · 2022-10-09T18:01:24Z

Thanks for your review (especially for the hint by extended using "super").
I've separated method printInhabitant in order to make DRY-er code, and also use some contractions for made the out string/array of the inhabitants (in fact I've already used that type of array construction in one of the previous commits, but wasn't sure if it correct in this exercise).
Please re-review it again, many thanks

OleksiyRudenko

@unabyband almost there

OleksiyRudenko · 2022-10-09T20:11:04Z

submissions/unabyband/oop_exercise/index.js

+  }
+
+  printInhabitant() {
+    super.printToPage(this.species,


Why not re-use parent's printInhabitant and then adding what is specific to this class?
I see, because parent's printInhabitant is not really re-usable as it returns nothing.
Use print function completely outside of classes definition.

I've made it, please review again

OleksiyRudenko

@unabyband let's make it OOP compliant in one final step.

OleksiyRudenko · 2022-10-10T11:20:28Z

submissions/unabyband/oop_exercise/index.js

+    return [this.species,
+        `<strong>${this.name}</strong>`,
+        this.gender,
+        `On ${this.legs} legs`,
+        `Has ${this.hands} hands`,
+        `<em>${this.saying}</em>`,
+        this.friends.map((friend) => friend.name).join(", ")].join('; ');


Now re-use parent's version of the method and add whatever this class needs to add.
Let's have hands at the end for the sake of simplicity and in favour of OOP compliance.

Alternative would be to keep properties as array all way down until you need to print them. This way you could insert hands somewhere after legs or elsewhere. But this too much change. Please just keep this in mind. And attach hands at the end of the parent's method output.

I've made it, please review. And sorry for delayed answer, because of missile attacks we don't have an electricity and cable internet.
Thank you

OleksiyRudenko

@unabyband great job!

unabyband added 2 commits September 11, 2022 21:16

The first commit of OOP Exercise

15bcef8

Empty line at the end of the file

cab0026

A-Ostrovnyy added the task-TJSW-OOP label Sep 11, 2022

unabyband added 2 commits September 12, 2022 14:51

Edits after self-check

af41ce3

Edits after self-check

4893e64

OleksiyRudenko added the self-check-done Student confirmed that self-checks against requirements/common-mistakes are done label Sep 20, 2022

OleksiyRudenko requested changes Sep 26, 2022

View reviewed changes

Fixes after review

3f9c755

unabyband requested a review from OleksiyRudenko September 26, 2022 23:47

unabyband added 2 commits September 27, 2022 13:50

Remake printInhabitant function in order to use Array method

5b12ed8

Make printInhabitant function a bit simpler

ebeb063

OleksiyRudenko requested changes Sep 29, 2022

View reviewed changes

Rewritten addFriends function

f15a55a

unabyband requested a review from OleksiyRudenko September 29, 2022 22:50

OleksiyRudenko self-assigned this Sep 29, 2022

OleksiyRudenko added the Stage0.1 label Oct 1, 2022

unabyband added 3 commits October 2, 2022 00:12

Improve the extented hands/legs/paws out and animal species

f27c9c3

Modify addFriends function using method add

6b010d5

Avoid "for" cycle in the addFriends function

94e19ca

OleksiyRudenko requested changes Oct 5, 2022

View reviewed changes

Remake legs/hands/paws prop for acnestor and child classes

e7c095a

unabyband requested a review from OleksiyRudenko October 5, 2022 17:03

unabyband added 2 commits October 6, 2022 15:26

A little improvement for names and props in Human subclass

1c689f0

Rewrote method of base class in Human sub-class for printing out "han…

426d207

…ds" property

OleksiyRudenko requested changes Oct 9, 2022

View reviewed changes

Separate concerns for DRY-er code and also use super for call parent …

6fcd5a2

…class method

unabyband requested a review from OleksiyRudenko October 9, 2022 18:01

OleksiyRudenko requested changes Oct 9, 2022

View reviewed changes

Add return into printIhnabitant method for re-using it

b87e272

unabyband requested a review from OleksiyRudenko October 9, 2022 20:45

OleksiyRudenko requested changes Oct 10, 2022

View reviewed changes

Re-using parent class method and add hands property for Human at the end

78f42bc

unabyband requested a review from OleksiyRudenko October 10, 2022 13:10

OleksiyRudenko approved these changes Oct 11, 2022

View reviewed changes

OleksiyRudenko merged commit 3915a9c into kottans:main Oct 11, 2022

OOP Exercise #518

OOP Exercise #518

Conversation

unabyband commented Sep 11, 2022

OOP Exercise

github-actions bot commented Sep 11, 2022

unabyband commented Sep 12, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OleksiyRudenko Sep 26, 2022 • edited Loading

Choose a reason for hiding this comment

unabyband Sep 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unabyband commented Sep 27, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

unabyband commented Sep 29, 2022 • edited Loading

unabyband commented Oct 4, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

OleksiyRudenko Oct 5, 2022 • edited Loading

Choose a reason for hiding this comment

unabyband Oct 5, 2022 • edited Loading

Choose a reason for hiding this comment

unabyband commented Oct 7, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unabyband commented Oct 9, 2022

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OleksiyRudenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OleksiyRudenko left a comment

Choose a reason for hiding this comment

OleksiyRudenko Sep 26, 2022 •

edited

Loading

unabyband Sep 27, 2022 •

edited

Loading

unabyband commented Sep 29, 2022 •

edited

Loading

OleksiyRudenko Oct 5, 2022 •

edited

Loading

unabyband Oct 5, 2022 •

edited

Loading