completed frogger-task #519
Conversation
|
Hey! Congratulations on your PR! 😎😎😎 Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code. Go through the requirements/most common mistakes linked below and fix the code as appropriate. If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat. When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly. Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒 Please, make sure that your code follows the requirements Universal recommendations:
By the way, you may proceed to the next task before this one is reviewed and merged. Sincerely yours, |
|
dear bot, dear mentors. |
OleksiyRudenko
added
the
self-check-done
There was a problem hiding this comment.
@sofiichuk nice start.
Needs improvements.
Pixel values are definitely calculable based on icons dimensions and playfield row numbers.
This would require certain research.
For example, how did you come up with numbers for initialPlayerPosition?
Also how river height is different from cell height?
How did you determine field width and height?
| if (player.x <= this.x + character.width && | ||
| player.x + character.width >= this.x && | ||
| player.y <= this.y + character.height && | ||
| player.y + character.height >= this.y) { | ||
| player.reset() |
There was a problem hiding this comment.
Item 4.iii of the requirements.
There was a problem hiding this comment.
replaced global variable's properties with enemy's own
| const enemy1 = new Enemy(0, 225, 100); | ||
| const enemy2 = new Enemy(0, 142, 200); | ||
| const enemy3 = new Enemy(0, 60, 150); |
There was a problem hiding this comment.
Mystery numbers. Item 3 (all subitems) of the requirements.
Also not DRY. Imagine you are tasked to add 10 more enemies. Minimize the effort.
There was a problem hiding this comment.
no more mystery numbers.
no mo repetitions.
p.s. also fixed two bugs that had been found during UAT.
p.p.s. please, review .this once again
There was a problem hiding this comment.
@sofiichuk global variables seem to be supernatural... while they are not.
| this.width = character.width; | ||
| this.height = character.height; | ||
| this.speed = speed; | ||
| this.rival = player; |
There was a problem hiding this comment.
player is still a global variable.
What blocks you from treating in the same way as you treat speed or coordinates?
Object Oriented JS
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.