Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS DOM task #537

Merged
merged 6 commits into from
Sep 26, 2022
Merged

JS DOM task #537

merged 6 commits into from
Sep 26, 2022

Conversation

wwwowka
Copy link
Contributor

@wwwowka wwwowka commented Sep 12, 2022

JavaScript DOM

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure you haven't made common mistakes

Universal recommendations:

  • Make sure your code follows General Requirements
  • Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

@madmaxWMFU madmaxWMFU self-assigned this Sep 22, 2022
Copy link
Contributor

@madmaxWMFU madmaxWMFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. See some comments below.

submissions/wwwowka/task_js_dom/script.js Outdated Show resolved Hide resolved
submissions/wwwowka/task_js_dom/script.js Outdated Show resolved Hide resolved
The value of the first page is in a separate variable.
@wwwowka
Copy link
Contributor Author

wwwowka commented Sep 24, 2022

Thanks for the review and advice. Made changes.
Didn't understand "Or try to destruction use and get zero elements of the data list."

submissions/wwwowka/task_js_dom/script.js Outdated Show resolved Hide resolved
submissions/wwwowka/task_js_dom/script.js Outdated Show resolved Hide resolved
wwwowka and others added 2 commits September 25, 2022 21:18
small fix

Co-authored-by: Maksym Yasenovyi <yasmaks@gmail.com>
refactoring

Co-authored-by: Maksym Yasenovyi <yasmaks@gmail.com>
Copy link
Contributor

@madmaxWMFU madmaxWMFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I approve of your work. Good luck with future tasks!

@madmaxWMFU madmaxWMFU merged commit 35a92a2 into kottans:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants