Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOP exersice #576

Merged
merged 3 commits into from
Oct 9, 2022
Merged

OOP exersice #576

merged 3 commits into from
Oct 9, 2022

Conversation

iva-stasia
Copy link
Contributor

OOP exersice

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements based on the most common mistakes as well as both basic and advanced requirements from the original task.

Universal recommendations:

  • Make sure your code follows General Requirements
  • Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

@iva-stasia
Copy link
Contributor Author

I checked it. It seems to me that everything is fine.

@OleksiyRudenko OleksiyRudenko added the self-check-done Student confirmed that self-checks against requirements/common-mistakes are done label Sep 20, 2022
@iva-stasia iva-stasia marked this pull request as draft September 20, 2022 18:08
@iva-stasia
Copy link
Contributor Author

I realized that I created Catwoman wrong. But I couldn't rewrite it using composition. I tried to find another solution, but when the cat's greeting changed, the Catwoman continued to say the old one. I don't seem to be able to find the right solution right now, so I'm deleting Catwoman for now.

@iva-stasia iva-stasia marked this pull request as ready for review September 21, 2022 11:53
@iva-stasia
Copy link
Contributor Author

While I was working on another task, I came up with a Catwoman solution. I hope such an option, as I did, is possible.

Copy link
Member

@OleksiyRudenko OleksiyRudenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iva-stasia well done!


class Inhabitant {
constructor(species, name, gender, legs, saying) {
this.species = species,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot that commas are not used in classes and was confused with the syntax of objects. Fixed in my repo.

@OleksiyRudenko OleksiyRudenko merged commit 91cd7dd into kottans:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
self-check-done Student confirmed that self-checks against requirements/common-mistakes are done Stage0.1 task-TJSW-OOP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants