A Tiny JS World #597
A Tiny JS World #597
Conversation
|
Hey! Congratulations on your PR! 😎😎😎 Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code. Go through the requirements/most common mistakes linked below and fix the code as appropriate. If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat. When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly. Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒 Please, make sure that your code follows the requirements based on the most common mistakes as well as basic requirements from the original task. Universal recommendations:
By the way, you may proceed to the next task before this one is reviewed and merged. Sincerely yours, |
|
Hi, I've checked the code for common errors as well as meeting the basic requirements of the initial task. Please review =) |
OleksiyRudenko
added
the
self-check-done
There was a problem hiding this comment.
@DeamonFire well done.
Check the comments below and put down a couple of insights for yourself.
| gender: 'female', | ||
| hands: 2, | ||
| legs: 2, | ||
| say: cat.say |
There was a problem hiding this comment.
Will cat-woman's saying change automagically when cat's does?
| const props = ['species', 'name', 'gender', 'hands', 'legs', 'say']; | ||
|
|
||
| // ======== OUTPUT ======== | ||
| const residents = habitansWorld |
There was a problem hiding this comment.
Is it residents per se that are stored in this variable? Looks like residents is synonym to "habitans".
Think of the naming that describes what is actually stored in a variable.
| say: cat.say | ||
| }; | ||
|
|
||
| const habitansWorld = [dog, cat, woman, man, catWoman]; |
There was a problem hiding this comment.
I often wonder where the wrong word "habitans" comes from in many works. Looks like it spreads as a pandemic across submissions.
A Tiny JS World
Demo|
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.