Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooli-style Popup #6

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Conversation

AntonKottans
Copy link
Contributor

Hooli-style Popup

Demo |
Code base

The code is submitted in a dedicated feature branch.
Please, review.

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work!
See my comments below.

submissions/antonkottans/hooli-style-popup/style.css Outdated Show resolved Hide resolved
submissions/antonkottans/hooli-style-popup/index.html Outdated Show resolved Hide resolved
submissions/antonkottans/hooli-style-popup/index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Couple small issues needs to be done)

submissions/antonkottans/hooli-style-popup/index.html Outdated Show resolved Hide resolved
submissions/antonkottans/hooli-style-popup/index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@A-Ostrovnyy A-Ostrovnyy merged commit aa36286 into kottans:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants