js-oop

[merowing]

js-oop

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements

In addition to the bot's suggestions above, please post a link to the app demo in Students' chat, collect feedback and fix bugs if any based on that. When user tests are done post here a comment on that.

Universal recommendations:

• Make sure your code follows General Requirements
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[merowing]

Reviewed and fix the code. All done.

[OleksiyRudenko]

@merowing good job!
Although improvements are required.
Check the requirements, in particular items 3 and 4.
Check your entire code against the requirements.

[OleksiyRudenko]

@merowing almost there.
You moved "global variable" problem from one method to another method within the class.
But we need to eliminate the problem, not just push it around.

[OleksiyRudenko]

A global variable.
The requirements provide a hint to resolution.

[merowing]

done

[OleksiyRudenko]

@merowing great job!