js-pre-oop

[merowing]

js-pre-oop

Demo |
Code base

This is the tiny JS World.

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[merowing]

What I did:

• used prettier
• used local live-server for check the code

[github-actions]

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements based on the most common mistakes as well as basic requirements from the original task.

Universal recommendations:

• Make sure your code follows General Requirements
• Use common sense or seek for an advice whenever requirements look ambiguous or unclear.
• Pay more attention to code style - descriptive variable names, indentations, empty spaces, etc. Code should look good :)

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

[OleksiyRudenko]

@merowing well done!
Check comments below for ideas to absorb and use when solving coding problems.

[OleksiyRudenko]

Devise a better naming. What does the variable actually contain?

[OleksiyRudenko]

switch is an impretaive way to write code.
Consider using a dictionary (object literal) to define modifiers for properties. Then building an output could be as short as .map(propertyName => `<${tags[propertyName]}>${creature[propertyName]}</${tags[propertyName]}>` )
This way the code would be more declarative, i.e. easier to read and modify.

P.S. There are "null" tags that you could benefit from.

Also consider splitting the handling of properties into a chain of transformations.
E.g. "Remove values that are 'empty', convert arrays into strings, format strings".
Having multiple simple operations vs one complex operation adds to readability and maintainability of code.