-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OOP exercise #682
Open
Dovahkiin1991
wants to merge
2
commits into
kottans:main
Choose a base branch
from
Dovahkiin1991:oop-exercise
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
OOP exercise #682
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
import { print } from './js/lib.js'; | ||
/* Refer to https://github.com/OleksiyRudenko/a-tiny-JS-world for the task details | ||
Complete the below for code reviewers' convenience: | ||
|
||
Code repository: https://github.com/Dovahkiin1991/a-tiny-JS-world | ||
Web app: https://dovahkiin1991.github.io/a-tiny-JS-world/ | ||
*/ | ||
// ======== OUTPUT ======== | ||
const UNSET_VALUE = 'unset'; | ||
class Creature { | ||
constructor(species, name, gender, legs, hands, saying) { | ||
this.species = species; | ||
this.name = name; | ||
this.gender = gender; | ||
this.legs = legs; | ||
this.hands = hands; | ||
this.saying = saying; | ||
} | ||
|
||
listOfProperties() { | ||
Dovahkiin1991 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return ` | ||
species - ${this.species = this.species || UNSET_VALUE}; | ||
name - ${this.name = this.name || UNSET_VALUE}; | ||
gender - ${this.gender = this.gender || UNSET_VALUE}; | ||
legs - ${this.legs = this.legs || UNSET_VALUE}; | ||
hands - ${this.hands = this.hands || UNSET_VALUE}; | ||
Dovahkiin1991 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
saying - ${this.saying = this.saying || UNSET_VALUE}; | ||
Dovahkiin1991 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
`; | ||
} | ||
} | ||
|
||
class Human extends Creature { | ||
constructor(species, name, gender, legs, hands) { | ||
super(species, name, gender, legs, hands, `Hey, my name is ${name}!`) | ||
} | ||
} | ||
|
||
class Man extends Human { | ||
constructor(name, gender, legs, hands, saying) { | ||
super('man', name, gender, legs, hands, saying) | ||
} | ||
} | ||
|
||
class Woman extends Human { | ||
constructor(name, gender, legs, hands, saying) { | ||
super('woman', name, gender, legs, hands, saying) | ||
Dovahkiin1991 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
|
||
class Animal extends Creature { | ||
constructor(species, name, gender, legs, hands, saying) { | ||
super(species, name, gender, legs, hands, saying) | ||
} | ||
} | ||
|
||
class Cat extends Animal { | ||
constructor(name, gender, legs) { | ||
super('cat', name, gender, legs, '', 'meuw-meuw!'); | ||
} | ||
} | ||
class Dog extends Animal { | ||
constructor(name, gender, legs) { | ||
super('dog', name, gender, legs, '', 'woof-woof!'); | ||
} | ||
} | ||
|
||
const inhabitantsList = [ | ||
new Man('Alex', 'male', 2, 2), | ||
new Woman('Katie', 'female', 2, 2), | ||
new Cat('Simba', 'female', 4), | ||
new Dog('Toby', 'male', 4), | ||
]; | ||
|
||
inhabitantsList.map((inhabitant) => { | ||
print(inhabitant.listOfProperties(), 'div'); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hands are inherited by all animals. They just do not need them.
OOP helps to define properties exactly where they needed. OOP in general and class syntax in particular is more powerful thing than just a tool to define default values for numerous properties.