Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Object Model task #90

Merged
merged 4 commits into from
Aug 14, 2022
Merged

Document Object Model task #90

merged 4 commits into from
Aug 14, 2022

Conversation

AsaMitaka
Copy link
Contributor

Document Object Model

Code
Demo

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@AsaMitaka AsaMitaka changed the title full dom Document Object Model task Aug 8, 2022
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
See my comments below.

submissions/asaMitaka/dom/index.html Outdated Show resolved Hide resolved
submissions/asaMitaka/dom/script.js Outdated Show resolved Hide resolved
submissions/asaMitaka/dom/script.js Outdated Show resolved Hide resolved
submissions/asaMitaka/dom/script.js Outdated Show resolved Hide resolved
submissions/asaMitaka/dom/script.js Show resolved Hide resolved
submissions/asaMitaka/dom/script.js Outdated Show resolved Hide resolved
submissions/asaMitaka/dom/script.js Outdated Show resolved Hide resolved
submissions/asaMitaka/dom/style.css Show resolved Hide resolved
submissions/asaMitaka/dom/style.css Show resolved Hide resolved
…, used event delegation, fixed removing classList .clicked, fixed backgroundColor on items, used class for each item, added css for mobile version
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!
Also, try to fix tablet view
image

submissions/asaMitaka/dom/script.js Outdated Show resolved Hide resolved
submissions/asaMitaka/dom/script.js Outdated Show resolved Hide resolved
submissions/asaMitaka/dom/script.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue left)

@@ -0,0 +1,201 @@
let content = document.querySelector('.content');

let aside = document.createElement('aside');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically it's not aside it's nav. The element inside aside tag was excluded from the main page context(the search bot ignored them)

@A-Ostrovnyy A-Ostrovnyy merged commit c15a18f into kottans:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants