-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Object Model task #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
See my comments below.
…, used event delegation, fixed removing classList .clicked, fixed backgroundColor on items, used class for each item, added css for mobile version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small issue left)
submissions/asaMitaka/dom/script.js
Outdated
@@ -0,0 +1,201 @@ | |||
let content = document.querySelector('.content'); | |||
|
|||
let aside = document.createElement('aside'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logically it's not aside
it's nav
. The element inside aside
tag was excluded from the main page context(the search bot ignored them)
Document Object Model
Code
Demo
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.