preoop task #91
Merged
preoop task #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Good job, could you please remove the |
OleksiyRudenko
requested changes
Aug 16, 2022
There was a problem hiding this comment.
@AsaMitaka good job!
Check the comment below and also add semicolons where appropriate. Adhering to a consistent code style is important.
|
|
||
| const inhabitants = [dog, cat, man, woman, catWoman]; | ||
|
|
||
| function aboutObj(obj) { |
There was a problem hiding this comment.
By convention, function names should start with a verb. This way we know it does something rather than contains/represents something.
OleksiyRudenko
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
@AsaMitaka well done! Approved.
In your future PRs, when you implemented all required changes either click Re-request review or, if it is not available, comment on a PR that you accomplished all required fixes and mention the reviewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building a Tiny JS World (pre-OOP)
Demo
Code
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.