-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preoop task #91
preoop task #91
Conversation
Hi! Good job, could you please remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AsaMitaka good job!
Check the comment below and also add semicolons where appropriate. Adhering to a consistent code style is important.
|
||
const inhabitants = [dog, cat, man, woman, catWoman]; | ||
|
||
function aboutObj(obj) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By convention, function names should start with a verb. This way we know it does something rather than contains/represents something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AsaMitaka well done! Approved.
In your future PRs, when you implemented all required changes either click Re-request review or, if it is not available, comment on a PR that you accomplished all required fixes and mention the reviewer.
Building a Tiny JS World (pre-OOP)
Demo
Code
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.