Friends app #95
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Friends App</title> | ||
| <link rel="stylesheet" href="style.css"> | ||
| <link rel="preconnect" href="https://fonts.googleapis.com"> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
| <link href="https://fonts.googleapis.com/css2?family=Roboto+Condensed:ital@1&display=swap" rel="stylesheet"> | ||
| </head> | ||
| <body> | ||
| <div class="container"> | ||
| <header class="header"> | ||
| <a class='header__a' href="https://kottans.org/" target="_blank">Kottans</a> | ||
| </header> | ||
|
|
||
| <main class="mainBlock"> | ||
| <div class="asideBlock"> | ||
| <form name="age" id="ageForm"> | ||
| <div class="asideBlock__items"> | ||
| <p>By Age</p> | ||
| <input type="radio" name="sort" id="ageMore"> | ||
| <label for="ageMore">Age < </label> | ||
| <input type="radio" name="sort" id="ageLess"> | ||
| <label for="ageLess">Age > </label> | ||
| </div> | ||
| <div class="asideBlock__items"> | ||
| <p>By Last Name</p> | ||
| <input type="radio" name="sort" id="lastAToZ"> | ||
| <label for="lastAToZ">A-Z</label> | ||
| <input type="radio" name="sort" id="lastZToA"> | ||
| <label for="lastZToA">Z-A</label> | ||
| </div> | ||
| </form> | ||
|
|
||
| <form name="gender" id="genderForm"> | ||
| <div class="asideBlock__items"> | ||
| <input type="radio" id="male" | ||
| name="gender"> | ||
| <label for="male" class="gender">Male</label> | ||
|
|
||
| <input type="radio" id="female" | ||
| name="gender"> | ||
| <label for="female">Female</label> | ||
|
|
||
| <input type="radio" id="all" | ||
| name="gender" checked> | ||
| <label for="all">All</label> | ||
| </div> | ||
| </form> | ||
|
|
||
| <div class="asideBlock__items"> | ||
| <p>Search: </p> | ||
| <input type="text" name="search" id="search"> | ||
| </div> | ||
|
|
||
| <div class="asideBlock__items"> | ||
| <button id="reset">Reset</button> | ||
| </div> | ||
| </div> | ||
| <article class="articleBlock"></article> | ||
| </main> | ||
| <footer class="footer"> | ||
| <a class="footer__a" href="https://kottans.org/" target="_blank">Kottans</a> | ||
| </footer> | ||
| </div> | ||
| <script src="script.js"></script> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,161 @@ | ||
| const url = 'https://randomuser.me/api/?results=12'; | ||
| const content = document.querySelector('.articleBlock'); | ||
| const ageForm = document.querySelector('#ageForm'); | ||
| const genderForm = document.querySelector('#genderForm'); | ||
| const search = document.querySelector('#search'); | ||
| let friends = []; | ||
| let friendsCopy = []; | ||
|
|
||
| const data = (url) => fetch(url) | ||
|
|
||
| .then(handleErrors) | ||
| .then(res => res.json()) | ||
| .then(res => { | ||
| friends = [...res.results]; | ||
| init(); | ||
| }); | ||
|
|
||
| function handleErrors(res) { | ||
| if (!res.ok) { | ||
| throw Error(res.statusText); | ||
| } | ||
| return res; | ||
| } | ||
|
|
||
| const filterState = { | ||
| search: null, | ||
| gender: null, | ||
| sort: null, | ||
| reset() { | ||
| this.search = null; | ||
| this.gender = null; | ||
| this.sort = null; | ||
| } | ||
| } | ||
|
|
||
| function filterBy(id, usersToFilter) { | ||
|
There was a problem hiding this comment. I believe the only id you have there is somehow connected with gender, so |
||
| switch(id) { | ||
|
There was a problem hiding this comment. You can shorten this switch like this: switch(id) {
case 'male':
case 'female':
usersToFilter = userstoFilter.filter(item => item.gender === id);
break;
case 'all':
...
} |
||
| case 'male': | ||
| usersToFilter = usersToFilter.filter(item => item.gender === 'male'); | ||
| break; | ||
| case 'female': | ||
| usersToFilter = usersToFilter.filter(item => item.gender === 'female'); | ||
| break; | ||
| case 'all': | ||
| usersToFilter = [...friends]; | ||
|
There was a problem hiding this comment. First of all, it would be more readable to create a new variable, something like |
||
| break; | ||
| } | ||
| return usersToFilter; | ||
| } | ||
|
|
||
| function sortAge(a, b) { | ||
| return a.dob.age - b.dob.age; | ||
| } | ||
|
|
||
| function sortAlph(a, b) { | ||
|
|
||
| return a.name.last !== b.name.last ? a.name.last < b.name.last ? -1 : 1 : 0; | ||
| } | ||
|
|
||
| function sortBy(id, usersToSort) { | ||
| switch(id) { | ||
| case 'ageMore': | ||
| usersToSort = usersToSort.sort((a, b) => sortAge(a, b)); | ||
| break; | ||
| case 'ageLess': | ||
| usersToSort = usersToSort.sort((a, b) => sortAge(b, a)); | ||
| break; | ||
| case 'lastAToZ': | ||
| usersToSort = usersToSort.sort((a, b) => sortAlph(a, b)); | ||
| break; | ||
| case 'lastZToA': | ||
| usersToSort = usersToSort.sort((a, b) => sortAlph(b, a)); | ||
| break; | ||
| } | ||
|
|
||
| return usersToSort; | ||
| } | ||
|
|
||
| function filterBySearch(searchValue, usersToSearch) { | ||
| return usersToSearch.filter((elem) => | ||
| `${elem.name.first}${elem.name.last}`.toLowerCase().includes(searchValue.toLowerCase()) | ||
| ); | ||
| }; | ||
|
|
||
|
|
||
|
|
||
| function creatingProfileCard({picture, name, email, dob, phone, location, gender}) { | ||
| return ` | ||
| <div class='content__item'> | ||
| <img class='content__item-img' src='${picture.medium}'> | ||
| <div class='content__item-name'>${name.title} ${name.first} ${name.last}</div> | ||
| <p class='content__item-p content__item-email'> | ||
| <a class='content__item-a' href="mailto: ${email}" target="_blank"> ${email}</a> | ||
| </p> | ||
| <p class='content__item-p'>Age: ${dob.age}</p> | ||
| <a class='content__item-a' href='${phone}'>${phone}</a> | ||
| <p class='content__item-p content__item-country'>${location.country}, ${location.city}</p> | ||
| <div class='content__item-gender'>${gender}</div> | ||
| </div> | ||
| `; | ||
| } | ||
|
|
||
|
|
||
| function init() { | ||
| renderAllItemsToPage(friends); | ||
|
|
||
| document.querySelector('.asideBlock').addEventListener('input', ({target}) => { | ||
| if (target.name === 'gender') { | ||
| filterState.gender = target.id; | ||
| } | ||
|
|
||
| if (target.name === 'search') { | ||
| filterState.search = target.value; | ||
| } | ||
|
|
||
| if (target.name === 'sort') { | ||
| filterState.sort = target.id; | ||
| } | ||
|
|
||
| render(); | ||
| }); | ||
|
|
||
| document.querySelector('#reset').addEventListener('click', function() { | ||
| ageForm.reset(); | ||
| genderForm.reset(); | ||
| filterState.reset(); | ||
| search.value = ''; | ||
| friendsCopy = [...friends]; | ||
|
|
||
| render(); | ||
| }) | ||
| } | ||
|
|
||
| function render() { | ||
| friendsCopy = [...friends]; | ||
|
|
||
| if (filterState.gender) { | ||
| friendsCopy = filterBy(filterState.gender, friendsCopy); | ||
| } | ||
|
|
||
| if (filterState.sort) { | ||
| friendsCopy = sortBy(filterState.sort, friendsCopy); | ||
| } | ||
|
|
||
| if (filterState.search) { | ||
| friendsCopy = filterBySearch(filterState.search, friendsCopy); | ||
| } | ||
|
|
||
| renderAllItemsToPage(friendsCopy); | ||
| } | ||
|
|
||
| function renderAllItemsToPage(arr) { | ||
| content.innerHTML = ''; | ||
|
|
||
| let acc = ''; | ||
|
There was a problem hiding this comment. Instead of creating a string of elements, it would be better to use the |
||
| arr.forEach(item => { | ||
| acc += creatingProfileCard(item); | ||
| }); | ||
|
|
||
| content.innerHTML = acc; | ||
| } | ||
|
|
||
| data(url); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're still using separate forms. It makes your code more complicated in the JS. Why not tie it up in one form?