Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html css popup #97

Merged
merged 7 commits into from
Aug 17, 2022
Merged

Html css popup #97

merged 7 commits into from
Aug 17, 2022

Conversation

Tedzury
Copy link
Contributor

@Tedzury Tedzury commented Aug 8, 2022

HTML_CSS_POPUP

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

submissions/Oleksii_Drohachov/HTML_CSS_PopUp/index.html Outdated Show resolved Hide resolved
submissions/Oleksii_Drohachov/HTML_CSS_PopUp/index.html Outdated Show resolved Hide resolved
submissions/Oleksii_Drohachov/HTML_CSS_PopUp/index.html Outdated Show resolved Hide resolved
submissions/Oleksii_Drohachov/HTML_CSS_PopUp/index.html Outdated Show resolved Hide resolved
submissions/Oleksii_Drohachov/HTML_CSS_PopUp/index.html Outdated Show resolved Hide resolved
submissions/Oleksii_Drohachov/HTML_CSS_PopUp/index.html Outdated Show resolved Hide resolved
submissions/Oleksii_Drohachov/HTML_CSS_PopUp/style.css Outdated Show resolved Hide resolved
submissions/Oleksii_Drohachov/HTML_CSS_PopUp/style.css Outdated Show resolved Hide resolved
@Tedzury
Copy link
Contributor Author

Tedzury commented Aug 12, 2022

Good evening. Humbly asking for review, hope I fixed everything, what is needed. :)

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!
Two small issue left)

submissions/Oleksii_Drohachov/HTML_CSS_PopUp/index.html Outdated Show resolved Hide resolved
submissions/Oleksii_Drohachov/HTML_CSS_PopUp/index.html Outdated Show resolved Hide resolved
@Tedzury
Copy link
Contributor Author

Tedzury commented Aug 13, 2022

Good evening, hope, now I fixed everything )

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check your markup in validator
Also, add cursor: pointer to all interactive elements

submissions/Oleksii_Drohachov/HTML_CSS_PopUp/index.html Outdated Show resolved Hide resolved
@A-Ostrovnyy A-Ostrovnyy self-assigned this Aug 16, 2022
@Tedzury
Copy link
Contributor Author

Tedzury commented Aug 16, 2022

Good evening again!) Sorry for my abcence for few day. Fixed useless divs, validation error and cursor.

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@A-Ostrovnyy A-Ostrovnyy merged commit c020b58 into kottans:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants