Add codespell config and workflow (to detect new typos) + fix some typos #429
Conversation
Modify a rule to allow a non-required string with a `minLength` >= 1 to be an empty string
…ld-rule fix: always accept empty string if string is non-required
Replace CommonJS with ES6 imports
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2 ./doc/components/wrappers/v-jsf-table.vue",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
Hello, thanks for the effort but I only do some minimal maintenance on this branch. The work is focused in the "next" branch. What does the github action do ? Does it block if there are typos ? I like the functionality of codespell, but I don't know if it warrants bringing this extra complexity. It would be nice if it acted a bit like dependabot, just making suggestions in PRs. |
should I rebase?
it just fails CI -- you are still welcome to force the hand and merge the PR, but you better fix the typos and make it happy ;)
no such convenience just yet ... may be in the future. But typically it is just a few typos, easy to review/fix and push a fix. |
A token of gratitude (or a bribe to facilitate review #428 ;) ): add https://github.com/codespell-project/codespell support and get some typos fixed.
TODOs:
lib/utils/expr-eval-parser.jsare ok since seems to fix there... looking at https://github.com/silentmatt/expr-eval/blob/HEAD/parser.d.ts#L22 (if I got the target interface right) -- seems to be correct fixes