Skip to content
This repository has been archived by the owner on Sep 6, 2020. It is now read-only.

Added support for headers in SocketIORequest #33

Merged
merged 1 commit into from
Apr 11, 2014
Merged

Added support for headers in SocketIORequest #33

merged 1 commit into from
Apr 11, 2014

Conversation

sergiocampama
Copy link

Added a new constructor that accepts a List<BasicNameValuePair> containing
extra headers to add to the HttpPost request.

Added a new constructor that accepts a `List<BasicNameValuePair>` containing
extra headers to add to the `HttpPost` request.
koush added a commit that referenced this pull request Apr 11, 2014
Added support for headers in SocketIORequest
@koush koush merged commit 460bd2c into koush:master Apr 11, 2014
@koush
Copy link
Owner

koush commented Apr 11, 2014

this library is outdated, please look https://github.com/koush/AndroidAsync

@sergiocampama
Copy link
Author

Oh, I hadn't checked AndroidAsync for SocketIO support. I see that there
isn't support for headers in SocketIORequest in AndroidAsync, is it ok for
me to port this commit there?


Sergio Campamá
sergiocampama@gmail.com

On Fri, Apr 11, 2014 at 5:27 PM, Koushik Dutta notifications@git.luolix.topwrote:

this library is outdated, please look
https://github.com/koush/AndroidAsync

Reply to this email directly or view it on GitHubhttps://github.com//pull/33#issuecomment-40249806
.

@sergiocampama
Copy link
Author

My bad, I assumed that SocketIORequest extended from Object, but since it
extends from AsyncHttpRequest, it has headers support.

Cheers!


Sergio Campamá
sergiocampama@gmail.com

On Fri, Apr 11, 2014 at 5:30 PM, Sergio Campamá sergiocampama@gmail.comwrote:

Oh, I hadn't checked AndroidAsync for SocketIO support. I see that there
isn't support for headers in SocketIORequest in AndroidAsync, is it ok for
me to port this commit there?


Sergio Campamá
sergiocampama@gmail.com

On Fri, Apr 11, 2014 at 5:27 PM, Koushik Dutta notifications@git.luolix.topwrote:

this library is outdated, please look
https://github.com/koush/AndroidAsync

Reply to this email directly or view it on GitHubhttps://github.com//pull/33#issuecomment-40249806
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants