Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
ExactAttachment
header that doesn't require the use of anattachment://
URL scheme. This should simplify usingmark
as a tool for something like keeping GitHub and Confluence in sync at the cost of adding a tool that may give undesired behavior in some circumstances if used without caution.Unfortunately, I had to change the
pkg/mark/Meta
data structure to get an approach that was relatively easy on the eyes. However, I figured it might be a good place to make the change in case a syntactic change is preferable overExactAttachment
and/or regular expression replacement becomes a priority.I tried both attachment mechanisms with my local build and everything seems to be working with the refactor and the new header. In fact, I now have a GitHub and Confluence page that look more or less identical (including locally generated images) from the same markdown code, which was at least my own goal.