Add flag to append hash to pages to ensure unique titles #509
Conversation
| ) | ||
| path := strings.Join(append(meta.Parents, meta.Space, meta.Title), "/") | ||
| pathHash := sha256.Sum256([]byte(path)) | ||
| meta.Title = fmt.Sprintf("%s - %x", meta.Title, pathHash[0:4]) |
There was a problem hiding this comment.
| meta.Title = fmt.Sprintf("%s - %x", meta.Title, pathHash[0:4]) | |
| meta.Title = fmt.Sprintf("%s - %x", meta.Title, pathHash[:7]) |
let's take 7 characters here, just to be safe (in case someone generates a lot of pages)
There was a problem hiding this comment.
pathHash here is an array of bytes being printed as hexadecimal, so each byte is printed as two characters. The first four bytes and the first eight hexadecimal characters are the same, so I could change it to [:7] of the hex string if you think that is more clear.
Either way, I'll add a comment there since it isn't clear what's happening.
There was a problem hiding this comment.
Ah I didn't see that it's a byte array and hex representation. This looks good (and a comment is a good idea). Ignore my suggestion then :)
There was a problem hiding this comment.
I've added a comment for clarity, and included other suggestions.
Thanks for the review!
pwlandoll
force-pushed
the
feat/append-hash
branch
from
dde43e3
to
9ab0c67
Compare
|
Thanks for the contribution! |
This adds a command line flag and environment variable to configure mark to append hash values to page titles.
This helps solve the issue where multiple pages with the same name, but under different parents, will conflict (#450).
Another solution could be to allow arbitrary prefix/postfix text, and/or make this computed hash value available as a template variable to be inserted at any point.