Dont ignore err in close on atomicwrite

kovidgoyal · Sep 10, 2024 · 31aa4bc · 31aa4bc
1 parent a23fb15
commit 31aa4bc
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/tools/utils/atomic-write.go b/tools/utils/atomic-write.go
@@ -55,7 +55,11 @@ func AtomicWriteFile(path string, data io.Reader, perm os.FileMode) (err error)
 			if err == nil {
 				removed := false
 				defer func() {
-					f.Close()
+					if err == nil {
+						err = f.Close()
+					} else {
+						f.Close()
+					}
 					if !removed {
 						os.Remove(f.Name())
 						removed = true