Extend and tweak branch drawing symbols based on feedback #7805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These look unnaturally small on some screen sizes.
These symbols allow drawing branches merging into or forking out of commits directly rather than requiring that merges/forks are rendered on their own line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working with other terminal branch viewer authors to determine how they feel about the new extended branch characters.
The first change is to make commit circles slightly larger. There has been feedback that the circles are too small, which I agree with.
The second change is to add more commit symbols with branches connected to them at various angles.
Here are all the symbols, with the new symbols in the last two rows:
It can be hard to see what the new symbols are with the large commit circles, so here they are with lines next to them that show how they're connected:
The new symbols allow drawing the commit graph with branches merging directly into the commit rather than showing merges/forks on separate lines from commits.
My original goal was to provide a way to draw branches in every possible way.
This way was something I originally missed.
In case you think this will be a pattern, I believe the likelihood of realizing we could add a significant number of new branch symbols after this is low.
I did think of these symbols before, I just didn't think they would be useful.
There are only so many variations you can add, and this covers the rest of the possibilities as far as I can tell.
The new symbols still don't get close to any other symbol sets included in Nerd Fonts or Fira Code.