Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest Stackage snapshot #226

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Use latest Stackage snapshot #226

merged 3 commits into from
Oct 31, 2019

Conversation

chshersh
Copy link
Contributor

To make sure that it build with the latest Stackage snapshot and GHC-8.8.

@chshersh chshersh added the CI label Oct 31, 2019
@chshersh chshersh self-assigned this Oct 31, 2019
hint-man[bot]
hint-man bot approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

vrom911
vrom911 approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chshersh
Copy link
Contributor Author

Looks like tests are indeed not working... I will investigate this.

@chshersh
Copy link
Contributor Author

Okay, the bug is in the fact that GHC-8.8 silently changed its behaviour:disappointed: :confused: :unamused:

GHC-8.6.5

λ: l = [2, 1, 3] :: [Int]
λ: :sprint l
l = _

GHC-8.8.1

λ: l = [2, 1, 3] :: [Int]
λ: :sprint l
l = [2,1,3]

I just need to find a different example that works consistently on both GHC versions...

Why CI passes with cabal and doesn't pass locally — I don't know, that's a mystery.

@vrom911
Copy link
Member

vrom911 commented Oct 31, 2019

How has that happened, is that a GHC bug?

@chshersh
Copy link
Contributor Author

@vrom911 I don't know how this happened... But just in case I opened GHC bug report:

@chshersh
Copy link
Contributor Author

Okay, both cabal and stack are now building and passing tests with both GHC-8.6.5 and GHC-8.8.1 on my machine locally, but for some reasons, GitHub CI actions with nix are failing. When this nightmare ends...

@vrom911 vrom911 merged commit bfb5f60 into master Oct 31, 2019
@vrom911 vrom911 deleted the chshersh/stack branch October 31, 2019 10:10
@chshersh chshersh added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

@hint-man hint-man[bot] hint-man[bot] approved these changes

Assignees

@chshersh chshersh

Labels
CI Hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chshersh @vrom911