Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'unordered-containers' inspections #368

Closed
chshersh opened this issue Aug 7, 2020 · 0 comments · Fixed by #369
Closed

Update 'unordered-containers' inspections #368

chshersh opened this issue Aug 7, 2020 · 0 comments · Fixed by #369
Assignees
@chshersh
Labels
bug 🪲 Something isn't working inspection
Milestone
0.1.0.0: Customiz...

Comments

@chshersh
Copy link
Contributor

chshersh commented Aug 7, 2020

A new version of unordered-containers came out, and some inspections got broken. Looks like some functions were moved around, and we need to update our inspections as well:

Unfortunately, we don't have access to dependencies versions, so we can't really provide different inspections for different versions of dependencies. Thus, I think, supporting only the latest one will be enough, especially considering that this is a minor version bump up.
@chshersh chshersh added bug 🪲 Something isn't working inspection labels Aug 7, 2020
@chshersh chshersh added this to the 0.1.0.0: Customization milestone Aug 7, 2020
@chshersh chshersh self-assigned this Aug 7, 2020
chshersh added a commit that referenced this issue Aug 7, 2020
@chshersh
[#368] Update 'unordered-containers' inspections
6580e52 
Resolves #368
@chshersh chshersh mentioned this issue Aug 7, 2020
Merged
vrom911 pushed a commit that referenced this issue Aug 7, 2020
@chshersh
[#368] Update 'unordered-containers' inspections (#369)
efc7fe5 
* [#368] Update 'unordered-containers' inspections

Resolves #368

* Fix stack build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

Labels
bug 🪲 Something isn't working inspection
Projects
None yet
Milestone
0.1.0.0: Customization
Development

Successfully merging a pull request may close this issue.

[#368] Update 'unordered-containers' inspections kowainik/stan
1 participant
@chshersh