Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename warnings field in the configuration to ghc-options #269

Closed
chshersh opened this issue Dec 1, 2018 · 0 comments
Closed

Rename warnings field in the configuration to ghc-options #269

chshersh opened this issue Dec 1, 2018 · 0 comments
Assignees
@chshersh
Labels
config TOML configurations
Milestone
v1.3.0: Extended ...

Comments

@chshersh
Copy link
Contributor

chshersh commented Dec 1, 2018

Currently we have warnings field in .toml configuration file. But the purpose of this field is to add not only warnings, but also any other GHC flags and options. Thus it makes more sense to name this field as ghc-options rather then warnings.

Since this is a very breaking change, I propose the following strategy to deal with this:

Next release

  1. Add ghc-options field in addition to warnings.
  2. Tell message about deprecation of warnings field and suggestions to use ghc-options instead.

After release

  1. Drop warnings field.
@chshersh chshersh added the config TOML configurations label Dec 1, 2018
@chshersh chshersh mentioned this issue Dec 1, 2018
Closed
@chshersh chshersh assigned chshersh and unassigned chshersh Dec 25, 2018
@chshersh chshersh added this to the v1.3.0: Extended scaffolding milestone Feb 28, 2019
chshersh added a commit that referenced this issue Mar 5, 2019
@chshersh
[#269] Use 'ghc-options' instead of 'warnings'
c10fce2 
Resolves #269
@chshersh chshersh mentioned this issue Mar 5, 2019
Merged
6 tasks
vrom911 pushed a commit that referenced this issue Mar 6, 2019
@chshersh @vrom911
[#269] Use 'ghc-options' instead of 'warnings' (#294)
b6c3ecb 
* [#269] Use 'ghc-options' instead of 'warnings'

Resolves #269

* Fix CI and improve error message

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

Labels
config TOML configurations
Projects
None yet
Milestone
v1.3.0: Extended scaffolding
Development

No branches or pull requests
1 participant
@chshersh