[#272] [#275] Travis improvements for generated project #279
Conversation
vrom911
added
help wanted
CI
There was a problem hiding this comment.
I think it's okay to not use --install-cabal option (looks like this option is not supposed to be used in production) and keep failing GHC-8.0.2. Basically, this is not our problem 🙂 We can't move forward if we will support everything... I guess experienced users know what they are doing and can introduce necessary manual changes to .travis.yml by themselves.
| @@ -22,6 +23,10 @@ import Summoner.GhcVer (GhcVer) | |||
| defaultGHC :: GhcVer | |||
| defaultGHC = maxBound | |||
|
|
|||
| -- | Default version of the Cabal. | |||
| defaultCabal :: Text | |||
There was a problem hiding this comment.
Very nice idea to move this into separate variable!
There was a problem hiding this comment.
Yes, because our plans are to make it more flexible in the future :)
| - ghc-${ghcV} | ||
| - cabal-install-head | ||
| |] | ||
| travisCabalMatrixItem (showGhcVer -> ghcV) = [text|- ghc: $ghcV|] |
|
@chshersh I don't want to make not working settings, at least we shouldn't include this GHC version in Stack matrix and specify this behaviour explicitly somewhere with the reasoning. I will try to ask some people; probably somebody already solved this problem. |
|
@vrom911 This is a very reasonable approach 👍 I agree, let's first ask, maybe something can be done with this. Otherwise - I have no idea how to fix this problem... |
|
Not sure it's the best place but: https://twitter.com/vronnie911/status/1081317117977378816 (it's not really can be an issue to Stack, as they would say that this is feature) UPD: Created Stack ticket: |
|
Things to do:
|
| @@ -1,15 +1,29 @@ | |||
| {-# LANGUAGE QuasiQuotes #-} | |||
| {-# LANGUAGE ViewPatterns #-} | |||
|
|
|||
| {-| This module contains template for GitHub related docs: | |||
There was a problem hiding this comment.
This documentation is soooo niiice! 👏
vrom911
force-pushed
the
vrom911/272-cabal-travis
branch
from
2ea825d
to
bfad01e
Compare
It doesn't work for Stack when the version of GHC is 8.0.2 because it uses old Stack, not the one that is configured, but it shouldn't work with the old version of Cabal (manually writing
stack setup --no-terminal --install-cabal 2.2.0.1doesn't help as well.UPD: We decided not to add old GHC into Stack Travis matrix.
Resolves #272
Resolves #275
Checklist:
stylish-haskellfile.summonerand check that the changes work as expected.