Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#45] Add AppVeyor to hs-init #46

Merged
merged 3 commits into from
Jan 31, 2018
Merged

[#45] Add AppVeyor to hs-init #46

merged 3 commits into from
Jan 31, 2018

Conversation

chshersh
Copy link
Contributor

Resolves #45

I've added AppVeyor as a separate CLI flag. Maybe if --ci specifed we can add both Travis and AppVeyor. I'm not sure what is more convenient for users. Maybe somebody don't want to deal with Windows...

I've also performed some cosmetic changes. And added appveyor.yml to hs-init.
@vrom911 you probably need to add hs-init project to AppVeyor to launch builds. I don't know how chmod +x works on Windows and how can I launch hs-init --help on Windows so I just build it with ghc on Windows.

Here is the example of project I've created to test AppVeyor:

@chshersh chshersh added feature generated project Files, folder generation by the summoner labels Jan 18, 2018
@chshersh chshersh self-assigned this Jan 18, 2018
@chshersh chshersh requested a review from vrom911 January 18, 2018 18:26
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy with this changes! Looks great, thank for this very useful feature!
I've added hs-init at appveyor but it unfortunately fails for some reasons. It couldn't find any of the packages specified in the stack script. I remember specifying them in travis.yml before, probably something like this should be done in appveyor file.
https://github.com/vrom911/hs-init/blob/2d6ccbe336fe1dc4438d8ddbfeb835280ca316f8/.travis.yml#L25

README.md Outdated
[![MIT license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/vrom911/hs-init/blob/master/LICENSE)
[![Version 1.0.2](https://img.shields.io/badge/version-v1.0.2-fabfff.svg)](https://github.com/vrom911/hs-init/blob/master/CHANGELOG.md)
[![Version 1.0.2](https://img.shields.io/badge/version-v1.0.3-fabfff.svg)](https://github.com/vrom911/hs-init/blob/master/CHANGELOG.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it names the version twice: it the label and in the link, so the first one should be 1.0.3 also.
Yes, I know that it's not the best way to keep version updated, but I don't know to deal with it..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems 👌 I also don't know better way...

Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry! I thought I merged it loooong ago!
Thanks for these changes, that's awesome 🥇

@vrom911 vrom911 merged commit 81f6d0b into master Jan 31, 2018
@vrom911 vrom911 deleted the chshersh/45-windows-ci branch January 31, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature generated project Files, folder generation by the summoner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants