Make discriminators work with multiple keys pointing to the same schema #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1885 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
=======================================
Coverage ? 98.89%
=======================================
Files ? 37
Lines ? 4158
Branches ? 968
=======================================
Hits ? 4112
Misses ? 29
Partials ? 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ldej
force-pushed
the
duplicate-discriminator
branch
from
40a6568
to
3a5115f
Compare
ldej
force-pushed
the
duplicate-discriminator
branch
from
9154032
to
0d8f5ee
Compare
sthagen
pushed a commit
to sthagen/koxudaxi-datamodel-code-generator
that referenced
this pull request
Mar 17, 2024
…ma (koxudaxi#1885) * Make discriminators work with multiple keys pointing to the same schema * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Koudai Aono <koxudaxi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple keys in a discriminator mapping point to the same schema, only the last key would become part of the discriminator literal. This PR takes into account that multiple keys might be pointing to the same schema.
Fixes #1878