Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate files without model #2044

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

kmichel-aiven
Copy link
Contributor

Remove unused imports if there are no models in a module.

Once the unused imports are skipped, don't create the file if there is nothing left in it, unless its __init__.py.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4fa23a) to head (b94adb5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2044   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         4199      4202    +3     
  Branches       967       969    +2     
=========================================
+ Hits          4199      4202    +3     
Flag Coverage Δ
unittests 99.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #2044 will not alter performance

Comparing kmichel-aiven:kmichel-no-empty-files (b94adb5) with main (e4fa23a)

Summary

✅ 29 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main kmichel-aiven:kmichel-no-empty-files Change
🆕 test_main_jsonschema_no_empty_collapsed_external_model N/A 52.5 ms N/A

Remove unused imports if there are no models in a module.

Once the unused imports are skipped, don't create the file if there
is nothing left in it, unless its `__init__.py`.
@kmichel-aiven kmichel-aiven marked this pull request as ready for review July 23, 2024 23:17
@koxudaxi koxudaxi merged commit 5500c0f into koxudaxi:main Aug 6, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants