Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Support PyCharm EAP 211.* #181

Merged
merged 5 commits into from
Feb 11, 2021
Merged

Support PyCharm EAP 211.* #181

merged 5 commits into from
Feb 11, 2021

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Feb 9, 2021 •
edited
Loading

@koxudaxi koxudaxi marked this pull request as draft February 9, 2021 14:11
@koxudaxi
Remove deleted methods
dd6e97c 
Change sinceBuild to 211.5538.22
@koxudaxi koxudaxi mentioned this pull request Feb 9, 2021
Closed
@koxudaxi
Copy link
Owner Author

koxudaxi commented Feb 9, 2021

@sproshev
I create a PR for EAP 211.
Would you please review this PR?

@sproshev
Copy link
Contributor

looks good to me :)

@koxudaxi
Copy link
Owner Author

@sproshev
Thank you for your comment!!
Would you have another plan of changes on EAP 211 that is related to Python SDK?

@sproshev
Copy link
Contributor

There could be changes related to sdk but I hope they won't affect poetry plugin. I'll ask teammates, personally I don't plan any further changes in 211.

@koxudaxi
Copy link
Owner Author

@sproshev
OK, I will release this version soon.
If you get information changes, then could you please notice to me?
Thank you.

@koxudaxi koxudaxi marked this pull request as ready for review February 11, 2021 14:07
@koxudaxi koxudaxi merged commit 436f3a2 into master Feb 11, 2021
@koxudaxi koxudaxi deleted the support_pycharm_eap_211 branch February 11, 2021 15:00
@sproshev
Copy link
Contributor

Sure, I planned to inform but didn't expect that you'll move poetry plugin to 211 so soon :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koxudaxi @sproshev