Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittest failed in 241.13688.16-EAP-SNAPSHOT #887

Closed
koxudaxi opened this issue Feb 23, 2024 · 8 comments · Fixed by #917
Closed

Unittest failed in 241.13688.16-EAP-SNAPSHOT #887

koxudaxi opened this issue Feb 23, 2024 · 8 comments · Fixed by #917
Labels
bug Something isn't working

Comments

@koxudaxi
Copy link
Owner

Describe the bug
After 241.13688.16-EAP-SNAPSHOT, unittest is failed.
We should fix it before release it.

https://github.com/koxudaxi/pydantic-pycharm-plugin/actions/runs/7994205495/job/21879373618

@koxudaxi koxudaxi added the bug Something isn't working label Feb 23, 2024
@koxudaxi
Copy link
Owner Author

@KotlinIsland

platformVersion = 241.13688.16-EAP-SNAPSHOT

Can you help me a little?
My work has been stuck on this problem for the past few days.
I believe 2024.1 will be released soon and I need to fix the problem as soon as possible.
Running unittest on the latest version of EAP almost always fails.
At least I don't think this plugin is taken into account during unittest. (debugging does not reach the breakpoint)

Do you have any idea what it is?

@KotlinIsland
Copy link
Contributor

I can take a look

@KotlinIsland
Copy link
Contributor

@koxudaxi I played around with it for a while, but I can't figure it out.
I agree, it appears that the plugin is not being loaded, I suspect it is related to the changes in PythonMockSdk.create from ddda140

@koxudaxi
Copy link
Owner Author

koxudaxi commented Mar 1, 2024

@KotlinIsland
Thank you for your time.
I checked the related code of MockSdk and project fixtures.
But, They didn't change last month 🤔

Yes, I followed the changes.
https://github.com/JetBrains/intellij-community/blob/master/python/testSrc/com/jetbrains/python/PythonMockSdk.java

@KotlinIsland
Copy link
Contributor

KotlinIsland commented Mar 1, 2024

Ah yes... what do you think about specifying an older EAP that works properly then? Perhaps it's an issue with the EAP?

But EAPs expire very quickly... Perhaps this is a bad idea

@koxudaxi
Copy link
Owner Author

koxudaxi commented Mar 1, 2024

Ah yes... what do you think about specifying an older EAP that works properly then? Perhaps it's an issue with the EAP?

If it is one previous EAP, it will work.
The remedy is to release it once specifying the previous EAP version.
However, the unit test will not be able to be cleared in the new version in the future.
The API around typing changes rapidly with version upgrades, so unittest is a must.

If it is a bug in the latest EAP, it is fine 😢

But EAPs expire very quickly... Perhaps this is a bad idea

I agree.

@koxudaxi
Copy link
Owner Author

koxudaxi commented Mar 6, 2024

@KotlinIsland
Since we can't take time for this task, how about we set the unittest execution environment to 2023.3 for once?
I tested it at hand, and it works with 241-EPA (without unittest).
For now, we've released the 241-EAP version.

@koxudaxi
Copy link
Owner Author

We have no time, so we have turned off unittest and released it.
We will need to investigate again as unittest will be required in future versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants