Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 241 EAP #879

Merged
merged 8 commits into from
Feb 18, 2024
Merged

Support 241 EAP #879

merged 8 commits into from
Feb 18, 2024

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Feb 17, 2024

Closes: #876

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f285ed0) 72.60% compared to head (ff70df7) 72.09%.

Files Patch % Lines
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 55.55% 0 Missing and 4 partials ⚠️
src/com/koxudaxi/pydantic/Pydantic.kt 0.00% 0 Missing and 1 partial ⚠️
src/com/koxudaxi/pydantic/PydanticInspection.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   72.60%   72.09%   -0.52%     
==========================================
  Files          27       27              
  Lines        2099     2100       +1     
  Branches      640      643       +3     
==========================================
- Hits         1524     1514      -10     
- Misses        275      282       +7     
- Partials      300      304       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koxudaxi koxudaxi mentioned this pull request Feb 17, 2024
Copy link
Contributor

github-actions bot commented Feb 17, 2024

Qodana Community for Python

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.0
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Contributor

github-actions bot commented Feb 18, 2024

Qodana Community for Python

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@koxudaxi koxudaxi merged commit ddda140 into main Feb 18, 2024
3 of 5 checks passed
@koxudaxi koxudaxi deleted the support_241_EAP branch February 18, 2024 17:12
@skewty
Copy link

skewty commented Mar 11, 2024

Any chance a new build will go out anytime soon? I'd like to try out 2024.1 EAP and this plugin is holding me back since you already released your updated Ruff plugin.

@koxudaxi
Copy link
Owner Author

@skewty

#887
Sorry, I have not been able to release it.
As you can see in this issue, unittest is an error in the latest EAP.
The worst-case scenario is removing and releasing the unittest, but we would like to fix it if possible. (unittest is a must since API changes are made with every version upgrade)

I also asked a question on the Slack community here, but I didn't get any reply!:sweat:
https://plugins.jetbrains.com/slack/

@koxudaxi
Copy link
Owner Author

Sorry for the delay.
I have released a corresponding version 0.4.12

This is due to a workaround of commenting out the unittest, not solving the cause.

@skewty
Copy link

skewty commented Mar 15, 2024

Sorry for the delay.

2024.1 isn't even out yet! Your sorry is too much.
But thank you, again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PyCharm 2024.1
2 participants