Fix type-map edge case for parsable-type and acceptable-type #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
============================================
- Coverage 71.54% 71.11% -0.43%
+ Complexity 141 135 -6
============================================
Files 14 14
Lines 896 907 +11
Branches 268 270 +2
============================================
+ Hits 641 645 +4
- Misses 124 127 +3
- Partials 131 135 +4
Continue to review full report at Codecov.
|
koxudaxi
changed the title
koxudaxi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the type-map edge case.
we expect
HttpUrlispydantic.HttpUrl.But, actual path is
pydantic.networks.HttpUrl.This PR fixes this case.
Related issues
#99