Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type-map edge case for parsable-type and acceptable-type #118

Merged
merged 6 commits into from
Apr 29, 2020

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Apr 28, 2020

This PR fixes the type-map edge case.

we expect HttpUrl is pydantic.HttpUrl.

"pydantic.HttpUrl" = ["str"]

But, actual path is pydantic.networks.HttpUrl.
This PR fixes this case.

Related issues

#99

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #118 into master will decrease coverage by 0.42%.
The diff coverage is 76.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
- Coverage     71.54%   71.11%   -0.43%     
+ Complexity      141      135       -6     
============================================
  Files            14       14              
  Lines           896      907      +11     
  Branches        268      270       +2     
============================================
+ Hits            641      645       +4     
- Misses          124      127       +3     
- Partials        131      135       +4     
Impacted Files Coverage Δ Complexity Δ
src/com/koxudaxi/pydantic/PydanticInitializer.kt 81.81% <76.19%> (-3.90%) 16.00 <0.00> (-4.00)
src/com/koxudaxi/pydantic/PydanticConfigService.kt 75.00% <0.00%> (-12.50%) 12.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a2abd...ac00a04. Read the comment docs.

@koxudaxi koxudaxi changed the title Fix type map Fix type-map edge case for parsable-type and acceptable-type. Apr 28, 2020
@koxudaxi koxudaxi changed the title Fix type-map edge case for parsable-type and acceptable-type. Fix type-map edge case for parsable-type and acceptable-type Apr 28, 2020
@koxudaxi koxudaxi merged commit 2430460 into master Apr 29, 2020
@koxudaxi koxudaxi deleted the fix_type_map branch April 29, 2020 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant