Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(🎁) IDEA 2022.3 and jvm 17 #519

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Conversation

KotlinIsland
Copy link
Contributor

And misc changes from the plugin template

@KotlinIsland
Copy link
Contributor Author

java.lang.RuntimeException: java.lang.IllegalAccessException: module java.base does not open java.lang to unnamed module

What does that mean 🤔

@KotlinIsland
Copy link
Contributor Author

Probably something to do with Archived non-system classes are disabled because the java.system.class.loader property is specified (value = "com.intellij.util.lang.PathClassLoader"). To use archived non-system classes, this property must not be set Exception in thread "main" java.lang

@KotlinIsland
Copy link
Contributor Author

Could not write standard input to Gradle Test Executor 1. java.io.IOException: The pipe is being closed
🤔🤔🤔

@koxudaxi
Copy link
Owner

koxudaxi commented Aug 8, 2022

@KotlinIsland
I just came back.
I tried to update java to 17. And I got same error :(
I checked other major plugins like IntelliJ-rust.
They don't use java 17 yet.

@KotlinIsland KotlinIsland changed the title Update java to 17 2022.3 and jvm 17 Sep 24, 2022
@KotlinIsland KotlinIsland changed the title 2022.3 and jvm 17 IDEA 2022.3 and jvm 17 Sep 24, 2022
@KotlinIsland
Copy link
Contributor Author

@koxudaxi This error is no longer present, now it's just some tests that are failing, I have no idea how to resolve them though, any suggestions?

@KotlinIsland KotlinIsland force-pushed the update_java branch 4 times, most recently from c106769 to 734e951 Compare September 24, 2022 08:22
it!!.psiElement is PyTargetExpression
}.filterNot {
excludes.contains(it!!.lookupString)
val actual = (myFixture!!.completeBasic() ?: emptyArray()).filter {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completeBasic can return null, so I added a default value, this made one of the tests pass.

@KotlinIsland
Copy link
Contributor Author

@koxudaxi I don't understand why the tests are failing, I have manually tested the plugin in 2022.3 and it appears to be functioning correctly.

And other misc changes from the plugin template
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Base: 73.65% // Head: 73.65% // No change to project coverage 👍

Coverage data is based on head (b049081) compared to base (843f0ec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #519   +/-   ##
=========================================
  Coverage     73.65%   73.65%           
  Complexity      301      301           
=========================================
  Files            23       23           
  Lines          1799     1799           
  Branches        532      532           
=========================================
  Hits           1325     1325           
  Misses          191      191           
  Partials        283      283           
Flag Coverage Δ
unittests 73.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KotlinIsland
Copy link
Contributor Author

I've changed the platformVersion to 2022.2.1 and that has resolved the failing tests.

@KotlinIsland KotlinIsland changed the title IDEA 2022.3 and jvm 17 (🎁) IDEA 2022.3 and jvm 17 Sep 24, 2022
@koxudaxi koxudaxi merged commit b3ace8e into koxudaxi:master Sep 24, 2022
@KotlinIsland KotlinIsland deleted the update_java branch September 25, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants