Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dataclass default Value detection #604

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Dec 12, 2022

Closes #552

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 73.16% // Head: 73.03% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (e9f3a36) compared to base (7b3189e).
Patch coverage: 70.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   73.16%   73.03%   -0.14%     
==========================================
  Files          24       24              
  Lines        1789     1810      +21     
  Branches      549      558       +9     
==========================================
+ Hits         1309     1322      +13     
  Misses        200      200              
- Partials      280      288       +8     
Impacted Files Coverage Δ
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 74.42% <66.66%> (-0.35%) ⬇️
...koxudaxi/pydantic/PydanticDataclassTypeProvider.kt 69.81% <70.83%> (-0.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koxudaxi koxudaxi merged commit 1b9e20a into master Dec 13, 2022
@koxudaxi koxudaxi deleted the improve_dataclass_defaultValue_detection branch December 13, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no warning on instantiation of dataclass when fields, that define default as Field(...), are omitted
1 participant