Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing python class fields on auto-completion #62

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Sep 3, 2019

The PR fixes removing python class fields on auto-completion.
The plugin removes fields on auto-completion when reference subclass of pydantic.BaseModel and pydantic.dataclasses.dataclass.
However, a bug works on any class.
It means we can't see class attributes of any class on auto-completion.

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #62 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
+ Coverage     79.35%   79.41%   +0.06%     
  Complexity       76       76              
============================================
  Files             7        7              
  Lines           339      340       +1     
  Branches        111      112       +1     
============================================
+ Hits            269      270       +1     
  Misses           20       20              
  Partials         50       50
Impacted Files Coverage Δ Complexity Δ
...koxudaxi/pydantic/PydanticCompletionContributor.kt 83.33% <100%> (+0.14%) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8103b86...6b4655c. Read the comment docs.

@koxudaxi koxudaxi merged commit d238f50 into master Sep 3, 2019
@koxudaxi koxudaxi deleted the fix_to_remove_fields_on_class branch September 3, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant