Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong renaming of a local variable name is same as field name #681

Merged

Conversation

koxudaxi
Copy link
Owner

Closes: #484

@koxudaxi koxudaxi changed the title Fix wrong renaming of a local variable name is same as field name Fix wrong renaming of a local variable name is same as field name Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.06 ⚠️

Comparison is base (fbc42f3) 75.50% compared to head (ca29cec) 75.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
- Coverage   75.50%   75.44%   -0.06%     
==========================================
  Files          24       24              
  Lines        1792     1796       +4     
  Branches      555      559       +4     
==========================================
+ Hits         1353     1355       +2     
  Misses        177      177              
- Partials      262      264       +2     
Impacted Files Coverage Δ
...m/koxudaxi/pydantic/PydanticFieldSearchExecutor.kt 91.04% <0.00%> (+0.13%) ⬆️
...om/koxudaxi/pydantic/PydanticFieldRenameFactory.kt 92.06% <71.42%> (-2.94%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koxudaxi koxudaxi merged commit eaa9557 into main Mar 20, 2023
@koxudaxi koxudaxi deleted the Fix_wrong_renaming_of_local_variable_name_is_same_as_field_name branch March 20, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename refactoring on local variable also renames field if same name
1 participant