Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 232 EAP #717

Merged
merged 20 commits into from
Jun 23, 2023
Merged

support 232 EAP #717

merged 20 commits into from
Jun 23, 2023

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Jun 9, 2023

Closese:#713

@github-actions
Copy link
Contributor

Qodana

3204 new problems found

Name Severity Problems
Improper first parameter 🔴 Failure 6
Unsatisfied package requirements 🔶 Warning 257
Redeclared names without usages 🔶 Warning 230
Statement has no effect 🔶 Warning 121
Incorrect type 🔶 Warning 43
Incorrect call arguments 🔶 Warning 29
Unbound local variables 🔶 Warning 23
Unreachable code 🔶 Warning 14
Invalid type hints definitions and usages 🔶 Warning 2
Redundant character escape 🔶 Warning 1
init method that returns a value 🔶 Warning 1
Attempt to call a non-callable object 🔶 Warning 1
Wrong arguments to call super 🔶 Warning 1
PEP 8 coding style violation ◽️ Notice 1957
Unsatisfied package requirements ◽️ Notice 244
Unused local symbols ◽️ Notice 187
Shadowing names from outer scopes ◽️ Notice 25
Duplicated code fragment ◽️ Notice 17
Improper first parameter ◽️ Notice 12
Accessing a protected member of a class or a module ◽️ Notice 10
PEP 8 naming convention violation ◽️ Notice 8
Redundant parentheses ◽️ Notice 6
Shadowing built-in names ◽️ Notice 5
Suspicious relative imports ◽️ Notice 3
Assigning function calls that don't return anything ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@github-actions
Copy link
Contributor

Qodana

823 new problems found

Name Severity Problems
Improper first parameter 🔴 Failure 6
Redeclared names without usages 🔶 Warning 232
Statement has no effect 🔶 Warning 121
Unbound local variables 🔶 Warning 23
Unreachable code 🔶 Warning 14
Incorrect call arguments 🔶 Warning 12
Invalid type hints definitions and usages 🔶 Warning 3
Incorrect type 🔶 Warning 2
Attempt to call a non-callable object 🔶 Warning 1
init method that returns a value 🔶 Warning 1
Wrong arguments to call super 🔶 Warning 1
Unused local symbols ◽️ Notice 204
Class has no __init__ method ◽️ Notice 122
Shadowing names from outer scopes ◽️ Notice 23
Duplicated code fragment ◽️ Notice 17
Improper first parameter ◽️ Notice 13
Accessing a protected member of a class or a module ◽️ Notice 10
PEP 8 naming convention violation ◽️ Notice 8
Redundant parentheses ◽️ Notice 6
Suspicious relative imports ◽️ Notice 3
Assigning function calls that don't return anything ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@github-actions
Copy link
Contributor

Qodana

823 new problems found

Name Severity Problems
Improper first parameter 🔴 Failure 6
Redeclared names without usages 🔶 Warning 232
Statement has no effect 🔶 Warning 121
Unbound local variables 🔶 Warning 23
Unreachable code 🔶 Warning 14
Incorrect call arguments 🔶 Warning 12
Invalid type hints definitions and usages 🔶 Warning 3
Incorrect type 🔶 Warning 2
Attempt to call a non-callable object 🔶 Warning 1
init method that returns a value 🔶 Warning 1
Wrong arguments to call super 🔶 Warning 1
Unused local symbols ◽️ Notice 204
Class has no __init__ method ◽️ Notice 122
Shadowing names from outer scopes ◽️ Notice 23
Duplicated code fragment ◽️ Notice 17
Improper first parameter ◽️ Notice 13
Accessing a protected member of a class or a module ◽️ Notice 10
PEP 8 naming convention violation ◽️ Notice 8
Redundant parentheses ◽️ Notice 6
Suspicious relative imports ◽️ Notice 3
Assigning function calls that don't return anything ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -2.33 ⚠️

Comparison is base (360b9e3) 74.17% compared to head (25a609c) 71.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   74.17%   71.84%   -2.33%     
==========================================
  Files          25       25              
  Lines        1847     1847              
  Branches      571      571              
==========================================
- Hits         1370     1327      -43     
- Misses        212      254      +42     
- Partials      265      266       +1     
Impacted Files Coverage Δ
src/com/koxudaxi/pydantic/PydanticInitializer.kt 58.58% <100.00%> (-10.11%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Qodana

871 new problems found

Name Severity Problems
Improper first parameter 🔴 Failure 6
Redeclared names without usages 🔶 Warning 232
Statement has no effect 🔶 Warning 121
Unbound local variables 🔶 Warning 23
Unreachable code 🔶 Warning 14
Incorrect call arguments 🔶 Warning 12
Invalid type hints definitions and usages 🔶 Warning 3
Incorrect type 🔶 Warning 2
Attempt to call a non-callable object 🔶 Warning 1
init method that returns a value 🔶 Warning 1
Wrong arguments to call super 🔶 Warning 1
Unused local symbols ◽️ Notice 204
Class has no __init__ method ◽️ Notice 122
Duplicated code fragment ◽️ Notice 65
Shadowing names from outer scopes ◽️ Notice 23
Improper first parameter ◽️ Notice 13
Accessing a protected member of a class or a module ◽️ Notice 10
PEP 8 naming convention violation ◽️ Notice 8
Redundant parentheses ◽️ Notice 6
Suspicious relative imports ◽️ Notice 3
Assigning function calls that don't return anything ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@github-actions
Copy link
Contributor

Qodana

It seems all right 👌

No new problems found according to the checks applied
💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@koxudaxi koxudaxi merged commit 1a57892 into main Jun 23, 2023
@koxudaxi koxudaxi deleted the support_232_EAP branch June 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant