Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect untyped fields #93

Merged
merged 6 commits into from
Dec 12, 2019
Merged

inspect untyped fields #93

merged 6 commits into from
Dec 12, 2019

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Dec 11, 2019

The PR supports to inspect untyped fields. The warning is related to mypy plugin's option on pydantic.

Also, This inspection is an option. Users can toggle the option by settings.

Screen Shots.

screenshot14

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #93 into master will increase coverage by 0.18%.
The diff coverage is 61.9%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #93      +/-   ##
===========================================
+ Coverage     70.42%   70.6%   +0.18%     
+ Complexity       87      86       -1     
===========================================
  Files             8       8              
  Lines           595     609      +14     
  Branches        206     212       +6     
===========================================
+ Hits            419     430      +11     
- Misses           70      73       +3     
  Partials        106     106
Impacted Files Coverage Δ Complexity Δ
...koxudaxi/pydantic/PydanticCompletionContributor.kt 81.87% <0%> (ø) 1 <0> (ø) ⬇️
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 69.16% <100%> (+0.83%) 45 <0> (-1) ⬇️
src/com/koxudaxi/pydantic/Pydantic.kt 74.26% <50%> (-0.56%) 0 <0> (ø)
src/com/koxudaxi/pydantic/PydanticInspection.kt 66.66% <73.33%> (+2.25%) 2 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e161dd...5066c35. Read the comment docs.

@koxudaxi koxudaxi merged commit 352aa2d into master Dec 12, 2019
@koxudaxi koxudaxi deleted the inspect_warnUntypedFields branch December 12, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant